Use testthat 3 #1180
Use testthat 3 #1180
Conversation
There was a problem hiding this comment.
Thank you for the PR! This is a lot of work; I appreciate you putting the time in here.
Could you separate the test changes, vectorized rlang::is_installed(), name_repair silencing, and transitions from & to && in internals into separate PRs? That will help me review more informatively.
Merge commit 'ac745681daebddaaf3c5dda45e535a7fc98314e3' #Conflicts: # R/btergm-tidiers.R # R/muhaz-tidiers.R # man/glance.muhaz.Rd # man/tidy.btergm.Rd # man/tidy.muhaz.Rd
|
Thanks for triggering CI. As you see, there is still a lot of noise in the logs. I will try silencing most of it. It is mostly due to the fact that packages loaded in broom's tests are quite noisy on load. (when clicking on show testthat output) |
|
Noise in the logs is okay! What's more important is my ability to understand the change set comprehensively. As-is, there are still many changes that seem unrelated to the switch to testthat 3e—I'd welcome those other changes in separate PRs where their scope is more clearly defined, but will ask you to further pare back the changes here to only those needed to related to switching to 3e. |
|
This pull request has been automatically locked. If you believe the issue addressed here persists, please file a new PR (with a reprex: https://reprex.tidyverse.org) and link to this one. |
I also silenced a couple of tests / output along the way.