-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
regroup errors on zero-row data frames #486
Comments
@romainfrancois I think in this case we should get an index list of length 0. That will probably require flow through changes elsewhere. |
An 0-length index list is the way to go, yes. Although I'm kind of expecting that when there is a group, there is at least one element, so some things might break. |
@romainfrancois Any chance you can get to this one soonish? I've added a fair bit of workaround code for this in ggvis, and it would be nice to get rid of it. :) |
sure @wch I'll take a look. |
I think this commit took care of it. fd00ad2 |
Thanks! I think it works, but my tests still don't pass because now I'm running into #593. :-/ |
This causes problems for zero-row data in ggvis:
The text was updated successfully, but these errors were encountered: