fix fct_collapse group_other = TRUE misleveling #205
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix addresses the wrong leveling that occured due to assigning the old values to the new factor instead of both the new levels and the unchanged ones (who now become "Other")
|
This is actually already covered in #176, but hasn't been merged yet. |
|
Oh, I see - Would it be merged soon? |
I imagine so. |
Added the parameter name_other as a string with a default "Other". If group_other = TRUE, all levels not named in `...` would have the name given in name_other.
|
Thanks for the reply. Also added a name_other argument to allow to name the "Other" category differently and address issue #194 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix addresses the wrong leveling that occurred due to assigning the old values to the new factor instead of both the new levels and the unchanged ones (who then become "Other"). As far as I've tried it, it works... but I'm no R expert and also new to GitHub as well - just uses fct_collapse quite a lot.