Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too much vertical padding on code #309

Closed
hadley opened this issue May 7, 2019 · 3 comments · Fixed by #420
Closed

Too much vertical padding on code #309

hadley opened this issue May 7, 2019 · 3 comments · Fixed by #420

Comments

@hadley
Copy link
Member

hadley commented May 7, 2019

e.g. there should be white space between these lines

image

@jimhester
Copy link
Contributor

Looks like this is coming from

Just removing the margin: 0 line fixes it, but possibly may cause other undesired changes.

@hadley
Copy link
Member Author

hadley commented Apr 19, 2020

For reference blog post is https://www.tidyverse.org/blog/2019/05/vroom-1-0-0/

@hadley
Copy link
Member Author

hadley commented Apr 19, 2020

Ok, the root problem is not actually the code blocks — its the padding between list elements. Most lists appear to get a <p> embedded within the <li>, but some (like this one, do not). A good example of this is https://www.tidyverse.org/blog/2020/04/usethis-1-6-0/ — under github actions, the first list is just <li>..., the second is <li><p>...

Fortunately it looks like we can just add a margin to the bottom of <li> and the margin collapsing rules means that it still looks ok with the other form.

hadley added a commit that referenced this issue Apr 19, 2020
hadley added a commit that referenced this issue Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants