New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dplyr 0.8.0 release candidate post #220

Merged

batpigandme merged 33 commits into tidyverse:master from romainfrancois:post/dplyr_0.8.0

Dec 3, 2018

Member

romainfrancois commented Oct 23, 2018

WIP.

Collaborator

batpigandme commented Oct 23, 2018

Heads up: If you don't use .Rmarkdown the headers won't produce navigation links in the sidebar.

CONTRIBUTING.md for this repo is actually the guide for structuring posts (as opposed to the contributing guide in other t'verse repos). 😉

Member Author

romainfrancois commented Oct 23, 2018 •

edited

Loading

Thanks. Since I saw Rmd and Rmarkdown in other posts, I just assumed it was a matter of preference. Will update.

Collaborator

batpigandme commented Oct 23, 2018

Yeah, we didn't figure it out until relatively recently! That's why I was giving you the heads up (esp since I think that's how we all kind of end up doing things, so it's nice to have the right format going forward)! 😊

hadley reviewed

View reviewed changes

Member

hadley left a comment

A few high-level comments below. Feel free to request a review from me when you're closer

content/articles/2018-10-23-dplyr-0-8-0-release-candidate.Rmd Outdated Show resolved Hide resolved

content/articles/2018-10-23-dplyr-0-8-0-release-candidate.Rmd Outdated Show resolved Hide resolved

content/articles/2018-10-23-dplyr-0-8-0-release-candidate.Rmd Outdated


		# Less surprising hybrid evaluation

		Hybrid evaluation has been entirely redesigned to be more predictable

Member

hadley Oct 23, 2018

Re-iterate what hybrid evaluation is. Maybe integrate a brief description of unwind protect in to this section since it does make hybrid a little less important.

content/articles/2018-10-23-dplyr-0-8-0-release-candidate.Rmd Outdated

+                group_data()
+              ```
+              When we group by `x` then `f1` we initially split the data according to `x` which

Member

hadley Oct 23, 2018

Should mention filter() in here somewhere, and .preserve = FALSE

content/articles/2018-10-23-dplyr-0-8-0-release-candidate.Rmd Outdated Show resolved Hide resolved

content/articles/2018-10-23-dplyr-0-8-0-release-candidate.Rmd Outdated


		# colwise verbs

		TODO

Member

hadley Oct 23, 2018

Also mention last_col() and group_cols()

romainfrancois mentioned this pull request

filter() on grouped data reorders rows tidyverse/dplyr#3929

Closed

Member Author

romainfrancois commented Oct 24, 2018

I'll address the reviews as I progress ✍️ this.

Do we have a template for a post like this one whose goal is to encourage the community to give feedback before a major release ?

Collaborator

batpigandme commented Oct 24, 2018

Not really… We did a pre-release post for ggplot2 v3, but that was more of a heads up than "please test this out."

Member Author

romainfrancois commented Oct 24, 2018

Is an 🎱 picture ok for this, since this is for dplyr 0.8.0, e.g.

https://unsplash.com/photos/kU-WKSyTcp4

Member

hadley commented Oct 24, 2018

I love it!

jennybc reviewed

View reviewed changes

content/articles/2018-10-dplyr-0-8-0-release-candidate.Rmarkdown Outdated Show resolved Hide resolved

romainfrancois mentioned this pull request

filtering on the group column doesn't update the number of groups tidyverse/dplyr#3944

Closed

romainfrancois force-pushed the post/dplyr_0.8.0 branch from 0b42755 to 543c864 Compare

October 29, 2018 16:38

Member Author

romainfrancois commented Oct 29, 2018

@lionel- I'm not sure how to explain the updates re. colwise verbs, do you have something in mind ?

Member

lionel- commented Oct 29, 2018

These are mostly documentation changes right? Perhaps summarise the documentation updates: explain our new framing regarding explicit and implicit selections, and mention when groups are ignored or included. I can push a commit tomorrow if you like.

Member Author

romainfrancois commented Oct 29, 2018

Please do, i have family around this week 😀and so limited work time available 😬

Member Author

romainfrancois commented Oct 29, 2018

@krlmlr anything you’d like to add to the post ?

Member

hadley commented Oct 29, 2018

I think the main thing to mention for colwise() verbs is the transition from funs() to list(), and the fact that it's now consistent with purrr syntax.

krlmlr reviewed

View reviewed changes

Member

krlmlr left a comment

Looks good! Only typos and wording.

content/articles/2018-10-dplyr-0-8-0-release-candidate.Rmarkdown Outdated Show resolved Hide resolved

content/articles/2018-10-dplyr-0-8-0-release-candidate.Rmarkdown Outdated Show resolved Hide resolved

content/articles/2018-10-dplyr-0-8-0-release-candidate.Rmarkdown Outdated Show resolved Hide resolved

content/articles/2018-10-dplyr-0-8-0-release-candidate.Rmarkdown Outdated Show resolved Hide resolved

romainfrancois mentioned this pull request

Draft pre-release 0.8.0 blog post tidyverse/dplyr#3887

Closed

romainfrancois and others added 11 commits

December 3, 2018 11:52


          initial draft for dplyr 0.8.0 release candidate

d35db1a


          some progress

fddc8ff


          attempt to use gt

0fb2d7d


          revert use of gt for now


          unwind, nest_*

abcac6d


          Update content/articles/2018-10-dplyr-0-8-0-release-candidate.Rmarkdown

ea88d88

Co-Authored-By: romainfrancois <[email protected]>


          Update content/articles/2018-10-dplyr-0-8-0-release-candidate.Rmarkdown

8014ef9

Co-Authored-By: romainfrancois <[email protected]>


          Update content/articles/2018-10-dplyr-0-8-0-release-candidate.Rmarkdown

17a18b8

Co-Authored-By: romainfrancois <[email protected]>


          -many

504028a


          rephrase

3b2705e


          mention split_by()

69f4768

lionel- and others added 10 commits

December 3, 2018 11:52


          Mention soft-deprecation of funs()

654429c


          Mention new colwise documentation and group_cols()

dd620c6


          render

78e81b6


          plural

35dc539


          Mention the split() method

308f80a


          minor edits

127c970


          added scetion about new grouping functions

c2a3ea2


          mention article from Kieran Healy

e55f49c


          adapt to changes in group_map()

2ab9827


          udpate date and minor changes.

726db87

romainfrancois force-pushed the post/dplyr_0.8.0 branch from e1ba4be to 726db87 Compare

December 3, 2018 11:26


          links

8b931a8

hadley approved these changes

View reviewed changes

Member

hadley left a comment

Good to go once you've made the minor changes. (Don't forget to change the date)

content/articles/2018-12-dplyr-0-8-0-release-candidate.Rmarkdown Outdated Show resolved Hide resolved

content/articles/2018-12-dplyr-0-8-0-release-candidate.Rmarkdown Outdated Show resolved Hide resolved

content/articles/2018-12-dplyr-0-8-0-release-candidate.Rmarkdown Outdated Show resolved Hide resolved

content/articles/2018-12-dplyr-0-8-0-release-candidate.Rmarkdown Outdated Show resolved Hide resolved

content/articles/2018-12-dplyr-0-8-0-release-candidate.Rmarkdown Outdated Show resolved Hide resolved

content/articles/2018-12-dplyr-0-8-0-release-candidate.Rmarkdown Outdated Show resolved Hide resolved

content/articles/2018-12-dplyr-0-8-0-release-candidate.Rmarkdown Outdated Show resolved Hide resolved

content/articles/2018-12-dplyr-0-8-0-release-candidate.Rmarkdown Outdated Show resolved Hide resolved

content/articles/2018-12-dplyr-0-8-0-release-candidate.Rmarkdown Show resolved Hide resolved

content/articles/2018-12-dplyr-0-8-0-release-candidate.Rmarkdown Outdated Show resolved Hide resolved

hadley and others added 10 commits

December 3, 2018 16:40


          Update content/articles/2018-12-dplyr-0-8-0-release-candidate.Rmarkdown

e27bf87

Co-Authored-By: romainfrancois <[email protected]>


          Update content/articles/2018-12-dplyr-0-8-0-release-candidate.Rmarkdown

513b1ac

Co-Authored-By: romainfrancois <[email protected]>


          Update content/articles/2018-12-dplyr-0-8-0-release-candidate.Rmarkdown

9b95fee

Co-Authored-By: romainfrancois <[email protected]>


          suggested changes from @hadley

0d01564


          Merge branch 'post/dplyr_0.8.0' of https://github.com/romainfrancois/…

3ace090

…tidyverse.org into post/dplyr_0.8.0


          render

a336211


          update to match slug in article

4fe3eea


          using the %>%

59889b4


          less -> fewer

2d8d75a


          + planned release date

6e94d83

batpigandme reviewed

View reviewed changes

Collaborator

batpigandme left a comment

Woah!! This is a monster — but with lots of good stuff in it!
Mainly picky grammar stuff.
Also, you can delete the image for this post that doesn't have an -sq or -wd suffix, since it won't be used anywhere.

content/articles/2018-12-dplyr-0-8-0-release-candidate.Rmarkdown Outdated Show resolved Hide resolved

content/articles/2018-12-dplyr-0-8-0-release-candidate.Rmarkdown Outdated Show resolved Hide resolved

content/articles/2018-12-dplyr-0-8-0-release-candidate.Rmarkdown Outdated Show resolved Hide resolved

content/articles/2018-12-dplyr-0-8-0-release-candidate.Rmarkdown Outdated Show resolved Hide resolved

content/articles/2018-12-dplyr-0-8-0-release-candidate.Rmarkdown Outdated Show resolved Hide resolved

content/articles/2018-12-dplyr-0-8-0-release-candidate.Rmarkdown Outdated Show resolved Hide resolved

content/articles/2018-12-dplyr-0-8-0-release-candidate.Rmarkdown Outdated Show resolved Hide resolved

content/articles/2018-12-dplyr-0-8-0-release-candidate.Rmarkdown Outdated Show resolved Hide resolved

content/articles/2018-12-dplyr-0-8-0-release-candidate.Rmarkdown Outdated Show resolved Hide resolved

content/articles/2018-12-dplyr-0-8-0-release-candidate.Rmarkdown Outdated Show resolved Hide resolved


          @batpigandme grammar changes 📝🙏

ed81d40

batpigandme merged commit 9909c54 into tidyverse:master

romainfrancois deleted the post/dplyr_0.8.0 branch

December 4, 2018 10:40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet