Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EGW status only if it has changed - [v1.34] #3580

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Update EGW status only if it has changed - [v1.34] #3580

merged 2 commits into from
Oct 30, 2024

Conversation

sridhartigera
Copy link
Contributor

Description

cherry-pick of #3577 to 1.34

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

sridhartigera and others added 2 commits October 30, 2024 13:56
@sridhartigera sridhartigera requested a review from a team as a code owner October 30, 2024 21:02
@marvin-tigera marvin-tigera added this to the v1.34.7 milestone Oct 30, 2024
@sridhartigera sridhartigera merged commit 4d0aca2 into tigera:release-v1.34 Oct 30, 2024
2 checks passed
@sridhartigera sridhartigera deleted the pick-egw-fix-134 branch October 30, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caseydavenport caseydavenport caseydavenport approved these changes

Assignees
No one assigned
Labels
docs-pr-required release-note-required
Projects
None yet
Milestone
v1.34.7
Development

Successfully merging this pull request may close these issues.
3 participants
@sridhartigera @caseydavenport @marvin-tigera