-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure CRDs are created on boot #3610
Merged
caseydavenport
merged 4 commits into
tigera:master
from
caseydavenport:casey-ensure-crds
Nov 27, 2024
Merged
Ensure CRDs are created on boot #3610
caseydavenport
merged 4 commits into
tigera:master
from
caseydavenport:casey-ensure-crds
Nov 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
coutinhop
reviewed
Nov 22, 2024
coutinhop
reviewed
Nov 25, 2024
coutinhop
reviewed
Nov 25, 2024
coutinhop
approved these changes
Nov 25, 2024
rene-dekker
reviewed
Nov 26, 2024
rene-dekker
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This was referenced Nov 29, 2024
rene-dekker
pushed a commit
that referenced
this pull request
Nov 29, 2024
* Ensure CRDs are created on boot * Add option to init CRDs and exit * Add config option for default product variant * Fix tenant name * Fix package name for default value --------- Co-authored-by: Casey Davenport <[email protected]>
rene-dekker
pushed a commit
that referenced
this pull request
Nov 29, 2024
* Ensure CRDs are created on boot * Add option to init CRDs and exit * Add config option for default product variant * Fix tenant name * Fix package name for default value --------- Co-authored-by: Casey Davenport <[email protected]>
rene-dekker
pushed a commit
that referenced
this pull request
Nov 29, 2024
* Ensure CRDs are created on boot * Add option to init CRDs and exit * Add config option for default product variant * Fix tenant name * Fix package name for default value --------- Co-authored-by: Casey Davenport <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make sure CRDs exist early in bootup, as we require these CRDs to be present in order to launch controllers.
For PR author
make gen-files
make gen-versions
For PR reviewers
A note for code reviewers - all pull requests must have the following:
kind/bug
if this is a bugfix.kind/enhancement
if this is a a new feature.enterprise
if this PR applies to Calico Enterprise only.