Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure CRDs are created on boot #3610

Merged
merged 4 commits into from
Nov 27, 2024

Conversation

caseydavenport
Copy link
Member

Description

Make sure CRDs exist early in bootup, as we require these CRDs to be present in order to launch controllers.

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

cmd/main.go Outdated Show resolved Hide resolved
cmd/main.go Outdated Show resolved Hide resolved
cmd/main.go Outdated Show resolved Hide resolved
Copy link
Member

@rene-dekker rene-dekker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@caseydavenport caseydavenport merged commit c289b2c into tigera:master Nov 27, 2024
5 checks passed
@caseydavenport caseydavenport deleted the casey-ensure-crds branch November 27, 2024 17:55
rene-dekker pushed a commit that referenced this pull request Nov 29, 2024
* Ensure CRDs are created on boot

* Add option to init CRDs and exit

* Add config option for default product variant

* Fix tenant name

* Fix package name for default value

---------

Co-authored-by: Casey Davenport <[email protected]>
rene-dekker pushed a commit that referenced this pull request Nov 29, 2024
* Ensure CRDs are created on boot

* Add option to init CRDs and exit

* Add config option for default product variant

* Fix tenant name

* Fix package name for default value

---------

Co-authored-by: Casey Davenport <[email protected]>
rene-dekker pushed a commit that referenced this pull request Nov 29, 2024
* Ensure CRDs are created on boot

* Add option to init CRDs and exit

* Add config option for default product variant

* Fix tenant name

* Fix package name for default value

---------

Co-authored-by: Casey Davenport <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants