Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CRDs. Add BANP. #3707

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Update CRDs. Add BANP. #3707

merged 1 commit into from
Jan 16, 2025

Conversation

fasaxc
Copy link
Member

@fasaxc fasaxc commented Jan 16, 2025

Description

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

Copy link
Member

@tmjd tmjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fasaxc
Copy link
Member Author

fasaxc commented Jan 16, 2025

/merge-when-ready squash-commits

@marvin-tigera
Copy link
Contributor

OK, I will merge the pull request when it's ready, squash the commits when I merge it, and leave the branch after I've merged it.

@tmjd
Copy link
Member

tmjd commented Jan 16, 2025

I'm merging this because I don't think the addition of the CRD has caused any of the failures.

@tmjd tmjd merged commit 08b73a5 into tigera:release-v1.37 Jan 16, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants