Use filterText for filtering candidates if available. #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yyoncho
approved these changes
Mar 14, 2019
Per spec filterText should be used for filtering when the server provides it. If it's not provided, label should be used. Some language server such as clangd adds some prefix to labels, such as empty spaces. They don't work well with prefix-based filter since the additional prefix will never match the completion prefix. Should fix #92 and may also help #79.
tigersoldier
force-pushed
the
fix-filter-text
branch
from
05f9b17 to
2562549
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per spec filterText should be used for filtering when the server provides it.
If it's not provided, label should be used.
Some language server such as clangd adds some prefix to labels, such as empty
spaces. They don't work well with prefix-based filter since the additional prefix
will never match the completion prefix.
Should fix #92 and may also help #79.