Fix "latest" tag fallback #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattstauffer
approved these changes
Aug 4, 2021
| } | ||
|
|
||
| public function getTags(): Collection | ||
| { | ||
| $response = json_decode($this->getTagsResponse()->getContents(), true); | ||
|
|
||
| return collect($response['results']) | ||
| [$numericTags, $alphaTags] = collect($response['results']) |
| return is_numeric($tag[0]); | ||
| }); | ||
|
|
||
| $sortedTags = $alphaTags->sortDesc(SORT_NATURAL) |
Comment on lines
+56
to
+59
| if ($sortedTags->contains('latest')) { | ||
| $sortedTags->splice($sortedTags->search('latest'), 1); | ||
| $sortedTags->prepend('latest'); | ||
| } |
| @@ -69,6 +79,6 @@ protected function buildTagsUrl(): string | |||
|
|
|||
| protected function tagsUrlTemplate(): string | |||
| { | |||
| return 'https://registry.hub.docker.com/v2/repositories/%s/%s/tags'; | |||
| return 'https://registry.hub.docker.com/v2/repositories/%s/%s/tags?page_size=1024'; | |||
There was a problem hiding this comment.
haha that was an easy way to do it!
|
Thank you so much @josecanhelp! |
@mattstauffer looks like you're only option is for Tighten to purchase Troika and reabsorb @josecanhelp 🤡 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker Hub paginates the tag list page and in order to pull the full list of tags, we would need to authenticate, which I've been trying to avoid for complexity sake. Luckily, we can expand the
page_sizeparameter and bump it up to read more tags without needing to authenticate.The next step to my solution is to partition the named tags and the numerical tags. We can rely on the higher numerical tags to be the "actual latest" tags and we can ignore the named tags when takeout is searching for "actual latest".