Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add traefik service #317

Merged
merged 3 commits into from
Apr 26, 2023
Merged

Add traefik service #317

merged 3 commits into from
Apr 26, 2023

Conversation

viicslen
Copy link
Contributor

@viicslen viicslen commented Apr 26, 2023

Adds traefik reverse proxy to the list of available services

@mattstauffer mattstauffer merged commit fa689d3 into tighten:main Apr 26, 2023
@mattstauffer
Copy link
Member

In one of your comments you wrote this:

// Cannot use $_SERVER superglobal since that's empty during UnitUnishTestCase;

What do you mean by UnitUnishTestCase?

@viicslen
Copy link
Contributor Author

Sorry I should have removed that, that snippet of code is from stackoverflow 😅

@mattstauffer
Copy link
Member

Ha! OK, I'll remove.

@mattstauffer
Copy link
Member

Extracted and re-wrote here: 6eda6b5

@viicslen
Copy link
Contributor Author

Extracted and re-wrote here: 6eda6b5

Yeah, that looks much better.

BTW, I'm not too sure but I think the Windows directory separator should also be included when trimming the trailing slash in the following line:

return rtrim($_SERVER['HOMEDRIVE'] . $_SERVER['HOMEPATH'], '/');

@mattstauffer
Copy link
Member

whoops, thanks! i missed that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants