-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate payload generation into new Ziggy class #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into the constructor
jakebathman
requested changes
Jun 29, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One change and a question. Good work! Approved for merge after that.
jakebathman
approved these changes
Jul 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good with this now that tests are all passing 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends and closes #272, extracting all the logic related to generating Ziggy's 'route payload' directly into a new
Ziggy
class that replaces the existingRoutePayload
. It also removes the staticcompile
method in favour of instantiating a new Ziggy object, and resolves the application router instance internally so it doesn't need to be passed in.The new
Ziggy
class also implementsJsonSerializable
, which means we canjson_encode()
it directly—this makes the use case in the original PR, returning Ziggy's payload as JSON directly from an endpoint, trivial:This PR contains significant breaking changes and will be included in Ziggy
1.0
. All code likeRoutePayload::compile($router)
will need to be replaced with something like(new Ziggy)->toArray()
or(new Ziggy)->toArray()['namedRoutes']
.@DanielCoulbourne if you have some time to take a look at this, I'd love to know if it's more or less what you were going for!