Fix empty root URL with absolute: false
#667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bakerkretzmar I think instead of the lookbehind you could have just applied the regex only to |
|
Hmm yeah that's true, although that'll leave a trailing slash on a 'home' route with no path, if there is one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #666. Wanted to use a Regex lookbehind but support for them was only added to Safari several months ago and that's cutting it a bit close I think. That being said, the strings Ziggy works with are so short that we probably don't need to worry about performance at all, so we could probably lean on advanced Regex functionality more...