-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added shared memory multi-server feature #917
base: main
Are you sure you want to change the base?
Conversation
Nothing too obvious to comment in the code.
I passed more details to Jarek in slack |
Any idea how this can or should be tested? |
37d3bb5
to
ba95458
Compare
ba95458
to
99db384
Compare
Tested briefly and audio works through shared mem. |
99db384
to
e0df8c1
Compare
Currently, audio and GUI data are sent using shared memory. It's controlled by the The testing process should focus on detecting potential file descriptor or socket leaks by stopping and restarting these services repeatedly. Additional tests can be performed using any Unix sockets-enabled app, e.g., netcat. Keep in mind that it requires allocating additional shared memory slots (the shmSlots option). It's possible to reuse already assigned slots, but it requires shutting down the server and client using it. VM1: server
VM2: client
|
Tested on Lenovo-X1
Detected problems:
|
e0df8c1
to
88a14a4
Compare
Updated the systemd kill signal for Waypipe: it now uses |
Tested again on Lenovo-X1 The bug is fixed. bat tests pass Monitored now all VMs with the test script while starting all apps and closing them. Number of file descriptors change as noticed before. Nothing suspicious there. |
Checked with native Orin AGX and NX
Notes:
|
Checked with crosscompile Orin AGX and NX' Issues:
|
But after another reboot the audio devices are back. |
It the last push I turned off sending audio through shared memory. So audio issues are unlikely related with this PR. |
Yes, I agree. Now when thinking what happened I believe that connecting to home wifi network with the same IP space than within ghaf virtual network might have caused the crash and also temporary loss of audio. |
a0302df
to
ac2a1a3
Compare
Created issue regarding the problem with cross-building for the ARM64 platform. |
ac2a1a3
to
8a4f4ae
Compare
8a4f4ae
to
841da51
Compare
The issue with cross compilation has been solved. The |
Signed-off-by: Jaroslaw Kurowski <[email protected]>
841da51
to
fe0f400
Compare
@jkuro-tii feel free to cherry-pick fix from 89955dc |
Description of changes
The memsocket application has been enhanced with the following new features and updates:
Introduced a Nix framework for the automatic generation of configurations for servers (currently supporting audio and video) and their clients.
Enabled the transfer of audio and video data via shared memory from application VMs to designated servers, including gui-vm and audio-vm.
Documentation: https://confluence.tii.ae/x/uEPOAg
Checklist for things done
x86_64
aarch64
riscv64
make-checks
and it passesnixos-rebuild ... switch
Instructions for Testing