region_cache: fix issue that LocateKey may returns a wrong region #1299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazycs520
approved these changes
Apr 18, 2024
cfzjywxk
approved these changes
Apr 18, 2024
Signed-off-by: zyguan <[email protected]>
zyguan
force-pushed
the
fix-locate-key-after-split
branch
from
c8285ff to
3c67959
Compare
MyonKeminta
approved these changes
Apr 18, 2024
13 tasks
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1122 (comment) here we introduce an issue: if a region is marked as NeedDelayedReload, then we try to reload it by id and return the new region directly without checking the range, which may cause
LocateKeyreturns a wrong region when the region is just splitted. To fix this issue, we can:loadRegion(by key)loadRegionByID), callloadRegionif it doesn't contain the keyHere we prefer the first solution for simplicity.