Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve region request log for diagnose #1300

Merged
merged 21 commits into from
Apr 29, 2024
Merged

improve region request log for diagnose #1300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
d6c8e6e
improve region request log for diagnose
crazycs520 Apr 23, 2024
9c5af68
rename struct
crazycs520 Apr 23, 2024
a57fd09
refine region error metric with store id label and add rpc error metric
crazycs520 Apr 24, 2024
127dd0f
Merge branch 'master' of https://github.com/tikv/client-go into refin…
crazycs520 Apr 24, 2024
96a9f97
refine comment
crazycs520 Apr 24, 2024
234ffb4
Merge branch 'master' of https://github.com/tikv/client-go into refin…
crazycs520 Apr 24, 2024
aef9264
refine code
crazycs520 Apr 24, 2024
1459709
restrict log
crazycs520 Apr 24, 2024
3644a8a
Merge branch 'master' of https://github.com/tikv/client-go into refin…
crazycs520 Apr 24, 2024
209753e
refine code
crazycs520 Apr 25, 2024
4b728e7
refine
crazycs520 Apr 25, 2024
b36d4a8
refine
crazycs520 Apr 25, 2024
aed1111
refine log
crazycs520 Apr 26, 2024
cea82a0
refine code
crazycs520 Apr 26, 2024
90e8738
fix test
crazycs520 Apr 28, 2024
0edb2ed
Merge branch 'master' of https://github.com/tikv/client-go into refin…
crazycs520 Apr 28, 2024
87ebba3
Merge branch 'master' into refine-log-and-rpc-stats
crazycs520 Apr 28, 2024
14f7a51
address comment
crazycs520 Apr 28, 2024
0fa24aa
refine
crazycs520 Apr 28, 2024
fd82389
refine
crazycs520 Apr 28, 2024
a4f9994
refine log
crazycs520 Apr 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions integration_tests/main_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ func TestMain(m *testing.M) {
opts := []goleak.Option{
goleak.IgnoreTopFunction("github.com/pingcap/goleveldb/leveldb.(*DB).mpoolDrain"),
goleak.IgnoreTopFunction("github.com/tikv/client-go/v2/txnkv/transaction.keepAlive"), // TODO: fix ttlManager goroutine leak
goleak.IgnoreTopFunction("github.com/tikv/client-go/v2/config/retry.(*Config).createBackoffFn.newBackoffFn.func2"),
crazycs520 marked this conversation as resolved.
Show resolved Hide resolved
}

goleak.VerifyTestMain(m, opts...)
Expand Down
8 changes: 4 additions & 4 deletions integration_tests/snapshot_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,13 +303,13 @@ func (s *testSnapshotSuite) TestSnapshotThreadSafe() {

func (s *testSnapshotSuite) TestSnapshotRuntimeStats() {
reqStats := tikv.NewRegionRequestRuntimeStats()
tikv.RecordRegionRequestRuntimeStats(reqStats.Stats, tikvrpc.CmdGet, time.Second)
tikv.RecordRegionRequestRuntimeStats(reqStats.Stats, tikvrpc.CmdGet, time.Millisecond)
reqStats.RecordRPCRuntimeStats(tikvrpc.CmdGet, time.Second)
reqStats.RecordRPCRuntimeStats(tikvrpc.CmdGet, time.Millisecond)
snapshot := s.store.GetSnapshot(0)
runtimeStats := &txnkv.SnapshotRuntimeStats{}
snapshot.SetRuntimeStats(runtimeStats)
snapshot.MergeRegionRequestStats(reqStats.Stats)
snapshot.MergeRegionRequestStats(reqStats.Stats)
snapshot.MergeRegionRequestStats(reqStats)
snapshot.MergeRegionRequestStats(reqStats)
bo := tikv.NewBackofferWithVars(context.Background(), 2000, nil)
err := bo.BackoffWithMaxSleepTxnLockFast(5, errors.New("test"))
s.Nil(err)
Expand Down
Loading
Loading