Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add slow log #328

Merged
merged 5 commits into from
Nov 19, 2021
Merged

add slow log #328

merged 5 commits into from
Nov 19, 2021

Conversation

marsishandsome
Copy link
Collaborator

@marsishandsome marsishandsome commented Nov 17, 2021 •
edited
Loading

Signed-off-by: marsishandsome [email protected]

What problem does this PR solve?

add slow log

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note

@marsishandsome marsishandsome force-pushed the feature/add-slow-log branch 18 times, most recently from 5d95a5d to ad64759 Compare November 18, 2021 08:18
@marsishandsome marsishandsome force-pushed the feature/add-slow-log branch 2 times, most recently from 6a2d285 to c48eec8 Compare November 18, 2021 09:14
zz-jason
zz-jason reviewed Nov 18, 2021
View reviewed changes
src/main/java/org/tikv/common/log/SlowLogImpl.java Outdated Show resolved Hide resolved
src/main/java/org/tikv/common/log/SlowLogTask.java Outdated Show resolved Hide resolved
src/main/java/org/tikv/common/log/SlowLogTaskEmptyImpl.java Outdated Show resolved Hide resolved
src/main/java/org/tikv/common/log/SlowLogTaskImpl.java Outdated Show resolved Hide resolved
src/main/java/org/tikv/common/log/SlowLogTaskImpl.java Outdated Show resolved Hide resolved
src/main/java/org/tikv/common/policy/RetryPolicy.java Outdated Show resolved Hide resolved
src/main/java/org/tikv/raw/RawKVClient.java Outdated Show resolved Hide resolved
src/test/java/org/tikv/raw/RawKVClientTest.java Outdated Show resolved Hide resolved
@marsishandsome marsishandsome force-pushed the feature/add-slow-log branch 4 times, most recently from f739b48 to 7b8554a Compare November 18, 2021 10:25
zz-jason
zz-jason reviewed Nov 18, 2021
View reviewed changes
src/main/java/org/tikv/common/log/SlowLogImpl.java Outdated Show resolved Hide resolved
src/main/java/org/tikv/common/log/SlowLogImpl.java Outdated Show resolved Hide resolved
src/main/java/org/tikv/common/log/SlowLogSpan.java Outdated Show resolved Hide resolved
src/main/java/org/tikv/common/log/SlowLogSpanImpl.java Outdated Show resolved Hide resolved
src/main/java/org/tikv/common/policy/RetryPolicy.java Outdated Show resolved Hide resolved
src/main/java/org/tikv/common/policy/RetryPolicy.java Outdated Show resolved Hide resolved
@marsishandsome marsishandsome force-pushed the feature/add-slow-log branch 8 times, most recently from f33da0a to ff05f70 Compare November 19, 2021 05:20
@marsishandsome
add slow log
c786eb8 
Signed-off-by: marsishandsome <[email protected]>
@marsishandsome
support SwitchLeader and gRPC Forward
17c878a 
Signed-off-by: marsishandsome <[email protected]>
@marsishandsome
add slow log time
5303520 
Signed-off-by: marsishandsome <[email protected]>
@marsishandsome
Copy link
Collaborator Author

/run-all-tests

birdstorm
birdstorm previously approved these changes Nov 19, 2021
View reviewed changes
Copy link
Collaborator

@birdstorm birdstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marsishandsome
rename timeout to threshold
dcbc172 
Signed-off-by: marsishandsome <[email protected]>
@marsishandsome
Copy link
Collaborator Author

/run-all-tests

@marsishandsome
address code review
5684904 
Signed-off-by: marsishandsome <[email protected]>
@marsishandsome
Copy link
Collaborator Author

/run-all-tests

birdstorm
birdstorm approved these changes Nov 19, 2021
View reviewed changes
Copy link
Collaborator

@birdstorm birdstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zz-jason
zz-jason approved these changes Nov 19, 2021
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marsishandsome marsishandsome merged commit a881a65 into tikv:release-3.1 Nov 19, 2021
@marsishandsome marsishandsome mentioned this pull request Dec 1, 2021
Merged
marsishandsome added a commit to marsishandsome/client-java that referenced this pull request Dec 1, 2021
@marsishandsome
add slow log (tikv#328)
cbce07b 
Signed-off-by: marsishandsome <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason approved these changes

@birdstorm birdstorm birdstorm approved these changes

@ti-srebot ti-srebot ti-srebot approved these changes

Assignees
No one assigned
Labels
status/LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marsishandsome @zz-jason @birdstorm @ti-srebot