[fix #193] fix cdc lose data by add resolved ts interval #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zeminzhou <[email protected]>
Signed-off-by: zeminzhou <[email protected]>
Signed-off-by: zeminzhou <[email protected]>
pingyu
reviewed
Aug 6, 2022
cdc/cdc/kv/region_worker.go
Outdated
| logicalTs := oracle.ExtractLogical(resolvedTs) | ||
| time := oracle.GetTimeFromTS(resolvedTs) | ||
|
|
||
| safeTime := time.Add(-cfg.ResolvedTsSafeInterval) |
There was a problem hiding this comment.
If time is less than cfg.ResolvedTsSafeInterval, suggest to just return the time.
A resolved-ts = 0 would be a legal one ?
Signed-off-by: zeminzhou <[email protected]>
Signed-off-by: zeminzhou <[email protected]>
Signed-off-by: zeminzhou <[email protected]>
Signed-off-by: zeminzhou <[email protected]>
haojinming
reviewed
Aug 8, 2022
haojinming
reviewed
Aug 8, 2022
haojinming
reviewed
Aug 8, 2022
Signed-off-by: zeminzhou <[email protected]>
Signed-off-by: zeminzhou <[email protected]>
pingyu
reviewed
Aug 8, 2022
cdc/cdc/kv/region_worker.go
Outdated
Comment on lines
735
to
736
| // resolved ts, which may be larger than the new leader appends key to ts. | ||
| // So we fallback the resolved ts to a safe interval to make sure it's correct. |
There was a problem hiding this comment.
Suggested change
| // resolved ts, which may be larger than the new leader appends key to ts. | |
| // So we fallback the resolved ts to a safe interval to make sure it's correct. | |
| // So we fallback the resolved ts to a safe interval to make sure it's correct. | |
| // See https://github.com/tikv/migration/issues/193. | |
| // TODO: fix the issue completely. |
Also suggest to write a full analysis in #193, to help us discuss with others, and completely fix it later.
| resolvedTs: (1<<18)*4*1000 + 1, | ||
| expected: (1<<18)*1000 + 1, | ||
| }, | ||
| } |
There was a problem hiding this comment.
Suggest to add boundary cases, e.g:
resolvedTs = 0- Physical clock less than
3s. - Physical clock equals to
3s.
Signed-off-by: zeminzhou <[email protected]>
Signed-off-by: zeminzhou <[email protected]>
Signed-off-by: zeminzhou <[email protected]>
Signed-off-by: zeminzhou <[email protected]>
Signed-off-by: zeminzhou <[email protected]>
Signed-off-by: zeminzhou <[email protected]>
Signed-off-by: zeminzhou <[email protected]>
|
@pingyu PTAL~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: zeminzhou [email protected]
What problem does this PR solve?
TiKV-CDC maybe lose data when region leader tranfer happend
Issue Number: close #193
Problem Description: TBD
What is changed and how does it work?
Add a safe interval for resolved ts
Code changes
Check List for Tests
This PR has been tested by at least one of the following methods: