[close #248] fix keyspan sink metrics #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pingyu <[email protected]>
|
@zeminzhou @haojinming PTAL, thanks~ |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #249 +/- ##
================================================
+ Coverage 61.2425% 61.3256% +0.0830%
================================================
Files 238 239 +1
Lines 20200 20202 +2
================================================
+ Hits 12371 12389 +18
+ Misses 6690 6675 -15
+ Partials 1139 1138 -1
*This pull request uses carry forward flags. Click here to find out more.
|
pingyu
added a commit
to pingyu/tikv-migration
that referenced
this pull request
Oct 9, 2022
Signed-off-by: pingyu <[email protected]> Signed-off-by: pingyu <[email protected]>
pingyu
added a commit
to pingyu/tikv-migration
that referenced
this pull request
Oct 9, 2022
Signed-off-by: pingyu <[email protected]> Signed-off-by: pingyu <[email protected]>
pingyu
added a commit
that referenced
this pull request
Oct 9, 2022
* [fix #246] fix unified sorter (#247) * fix unified sorter Signed-off-by: zeminzhou <[email protected]> * remove debug log Signed-off-by: zeminzhou <[email protected]> * add metric for the input event of puller Signed-off-by: zeminzhou <[email protected]> * remove puller input metric Signed-off-by: zeminzhou <[email protected]> * add back Signed-off-by: zeminzhou <[email protected]> Signed-off-by: zeminzhou <[email protected]> Signed-off-by: pingyu <[email protected]> * fix keyspan sink metrics (#249) Signed-off-by: pingyu <[email protected]> Signed-off-by: pingyu <[email protected]> * fix gh action Signed-off-by: pingyu <[email protected]> Signed-off-by: zeminzhou <[email protected]> Signed-off-by: pingyu <[email protected]> Co-authored-by: zzm <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: pingyu [email protected]
What problem does this PR solve?
Issue Number: close #248
Problem Description: Table sink output event metrics in Dataflow is not correct
What is changed and how does it work?
Fix metrics name & comment in Grafana.
Code changes
Check List for Tests
This PR has been tested by at least one of the following methods:
Side effects
Related changes