[close #343]fix cdc residue metrics #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zeminzhou <[email protected]>
|
/unit_test_in_verify_ci |
zeminzhou
changed the title
pingyu
reviewed
May 30, 2023
cdc/cdc/owner/owner.go
Outdated
| @@ -199,6 +199,14 @@ func (o *Owner) Tick(stdCtx context.Context, rawState orchestrator.ReactorState) | |||
| return state, nil | |||
| } | |||
|
|
|||
| // Close try to close the owner when the owner is not running. | |||
| // Note: This method must not be called with `Tick`. Please be careful. | |||
| func (o *Owner) Close(ctx cdcContext.Context) { | |||
There was a problem hiding this comment.
Suggest to name as CloseAllCaptures, as we are not closing Owner here.
Here has similar code block, suggest to reuse this function.
(And maybe we also need the wrapper of context.)
At last, we need to double check about the thread-safety.
pingyu
reviewed
May 30, 2023
cdc/cdc/processor/manager.go
Outdated
| @@ -155,6 +155,14 @@ func (m *Manager) sendCommand(tp commandTp, payload interface{}) chan struct{} { | |||
| return cmd.done | |||
| } | |||
|
|
|||
| // Close closes all processors. | |||
| // Note: This method must not be called with `Tick`. Please be careful. | |||
| func (m *Manager) Close() { | |||
There was a problem hiding this comment.
Suggest to name as SyncClose, and reuse in handling of commandTpClose command.
Signed-off-by: zeminzhou <[email protected]>
Signed-off-by: zeminzhou <[email protected]>
|
/run-unit-test |
1 similar comment
|
/run-unit-test |
Signed-off-by: zeminzhou <[email protected]>
|
/run-integration-test |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #342 +/- ##
================================================
- Coverage 61.0648% 60.9127% -0.1521%
================================================
Files 240 240
Lines 20285 20334 +49
================================================
- Hits 12387 12386 -1
- Misses 6778 6829 +51
+ Partials 1120 1119 -1
*This pull request uses carry forward flags. Click here to find out more.
|
|
/run-integration-test |
2 similar comments
|
/run-integration-test |
|
/run-integration-test |
Signed-off-by: zeminzhou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #343
Problem Description: TBD
What is changed and how does it work?
clean metrics againt
Code changes
Check List for Tests
This PR has been tested by at least one of the following methods:
Side effects
Related changes
To reviewers
Please follow these principles to check this pull requests:
(The above text mainly refers to TiDB Development Guide. It's also highly recommended to read about Writing code review comments)