address the comments

Signed-off-by: Ryan Leung <[email protected]>
tikv · Oct 10, 2019 · 0189cd5 · 0189cd5
1 parent a7c7d81
commit 0189cd5
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/server/cluster.go b/server/cluster.go
@@ -235,7 +235,7 @@ func (c *RaftCluster) runBackgroundJobs(interval time.Duration) {
 	for {
 		select {
 		case <-c.quit:
-			log.Info("metrics are resetting")
+			log.Info("metrics are reset")
 			c.resetMetrics()
 			log.Info("background jobs has been stopped")
 			return
@@ -1020,7 +1020,7 @@ func (c *RaftCluster) resetMetrics() {
 	statsMap := statistics.NewStoreStatisticsMap(c.opt, c.GetNamespaceClassifier())
 	stores := c.GetStores()
 	for _, s := range stores {
-		statsMap.ResetStore(s, c.storesStats)
+		statsMap.ResetStore(s)
 	}
 	statsMap.Reset()
 

diff --git a/server/statistics/store_collection.go b/server/statistics/store_collection.go
@@ -269,7 +269,7 @@ func (m *storeStatisticsMap) Observe(store *core.StoreInfo, stats *StoresStats)
 	stat.Observe(store, stats)
 }
 
-func (m *storeStatisticsMap) ResetStore(store *core.StoreInfo, stats *StoresStats) {
+func (m *storeStatisticsMap) ResetStore(store *core.StoreInfo) {
 	namespace := m.classifier.GetStoreNamespace(store)
 	stat, ok := m.stats[namespace]
 	if !ok {