Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support NewClient with context #1983

Closed
disksing opened this issue Dec 5, 2019 · 0 comments · Fixed by #1993
Closed

Support NewClient with context #1983

disksing opened this issue Dec 5, 2019 · 0 comments · Fixed by #1993
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. status/TODO The issue will be done in the future.
Milestone
v4.0.0-beta

Comments

@disksing
Copy link
Contributor

disksing commented Dec 5, 2019

Feature Request

Describe your feature request related problem:

When pd-servers are down, it takes up to 100s to retry.

Describe the feature you'd like:

Accept context in NewClient so it can be cancelled earlier.
@disksing disksing added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Dec 5, 2019
@disksing disksing added this to the v4.0.0-beta milestone Dec 5, 2019
@disksing disksing added the status/TODO The issue will be done in the future. label Dec 5, 2019
@disksing disksing mentioned this issue Dec 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. status/TODO The issue will be done in the future.
Projects
None yet
Milestone
v4.0.0-beta
Development

Successfully merging a pull request may close this issue.

client: support create with context oh-my-tidb/pd
1 participant
@disksing