Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: support create with context #1993

Merged
merged 2 commits into from
Dec 5, 2019
Merged

Conversation

disksing
Copy link
Contributor

@disksing disksing commented Dec 5, 2019

Signed-off-by: disksing [email protected]

What problem does this PR solve?

Fix #1983

What is changed and how it works?

add NewClientWithContext

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch
  • Need to be included in the release notes

@disksing disksing added needs-cherry-pick-release-3.0 The PR needs to cherry pick to release-3.0 branch. needs-cherry-pick-release-3.1 The PR needs to cherry pick to release-3.1 branch. component/client Client logic. labels Dec 5, 2019
@disksing disksing added this to the v4.0.0-beta milestone Dec 5, 2019
@disksing disksing requested review from lhy1024 and rleungx December 5, 2019 10:29
@codecov-io
Copy link

Codecov Report

Merging #1993 into master will increase coverage by <.01%.
The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1993      +/-   ##
==========================================
+ Coverage   77.41%   77.42%   +<.01%     
==========================================
  Files         178      178              
  Lines       18142    18149       +7     
==========================================
+ Hits        14045    14051       +6     
+ Misses       3014     3013       -1     
- Partials     1083     1085       +2
Impacted Files Coverage Δ
client/client.go 72.1% <90%> (+2.08%) ⬆️
pkg/testutil/operator_check.go 88.88% <0%> (-11.12%) ⬇️
server/kv/etcd_kv.go 75.32% <0%> (-6.5%) ⬇️
server/heartbeat_streams.go 69% <0%> (-6%) ⬇️
server/member/leader.go 75.51% <0%> (-5.62%) ⬇️
pkg/etcdutil/etcdutil.go 88.4% <0%> (-2.9%) ⬇️
server/schedule/operator_controller.go 83.75% <0%> (+0.18%) ⬆️
pkg/btree/btree.go 87.65% <0%> (+0.8%) ⬆️
server/grpc_service.go 58.96% <0%> (+0.86%) ⬆️
server/config/option.go 91.24% <0%> (+0.92%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d11bff1...93d1a3f. Read the comment docs.

@rleungx
Copy link
Member

rleungx commented Dec 5, 2019

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 5, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Dec 5, 2019

/run-all-tests

@sre-bot sre-bot merged commit 1881cab into tikv:master Dec 5, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Dec 5, 2019

cherry pick to release-3.0 failed

@sre-bot
Copy link
Contributor

sre-bot commented Dec 5, 2019

cherry pick to release-3.1 failed

@disksing disksing deleted the clientctx branch March 19, 2020 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/client Client logic. needs-cherry-pick-release-3.0 The PR needs to cherry pick to release-3.0 branch. needs-cherry-pick-release-3.1 The PR needs to cherry pick to release-3.1 branch. status/can-merge Indicates a PR has been approved by a committer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support NewClient with context
6 participants