-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
schedule: add option to disable namespace checker #1201
schedule: add option to disable namespace checker #1201
Conversation
Hi contributor, thanks for your PR. This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically. |
/ok-to-test |
@lerencao Thanks for your contribution! If it is convenient, could you help me add the document? The related documents are located here: https://github.com/pingcap/docs/blob/master/tools/pd-control.md and https://github.com/pingcap/docs-cn/blob/master/tools/pd-control.md |
@disksing Yes, I'm doing it. :) |
PR on docs: pingcap/docs-cn#840 and pingcap/docs#573 |
@lerencao Awesome! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
What have you changed? (required)
This PR add an option to disable namespace checker's region relocation scheduling.
The implementation uses #1140 for reference.
What are the type of the changes (required)?
How has this PR been tested (required)?
make dev
and manual test.Does this PR affect documentation (docs/docs-cn) update? (optional)
TODO: add later
Refer to a related PR or issue link (optional)
#1199
Benchmark result if necessary (optional)
Add a few positive/negative examples (optional)