schedule: fix store maybe always overloaded #1586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rleungx
added
type/bug
nolouch
reviewed
Jun 18, 2019
|
ooh, IMO the solution looks too tricky to understand. Is it possible to simply add a method |
|
Hmmm... Do we still need the overloaded state in store? If so, we may still need to reset this state. |
|
No need the state. Just use |
nolouch
reviewed
Jun 19, 2019
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
disksing
approved these changes
Jun 19, 2019
nolouch
approved these changes
Jun 20, 2019
rleungx
added a commit
to rleungx/pd
that referenced
this pull request
Jun 20, 2019
* fix store maybe always overloaded Signed-off-by: Ryan Leung <[email protected]>
disksing
pushed a commit
that referenced
this pull request
Jun 20, 2019
* fix store maybe always overloaded Signed-off-by: Ryan Leung <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
There are some cases which will cause the PD cannot generate operator since the store could be always overloaded and be filtered in the end.
What is changed and how it works?
This PR fixes this problem by removing reset logic.
Check List
Tests
Related changes