-
Notifications
You must be signed in to change notification settings - Fork 727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg, tools: improve the log message #1636
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nolouch <[email protected]>
nolouch
added
the
needs-cherry-pick-release-3.0
The PR needs to cherry pick to release-3.0 branch.
label
Jul 15, 2019
shafreeck
approved these changes
Jul 15, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
rleungx
reviewed
Jul 15, 2019
Signed-off-by: nolouch <[email protected]>
/ok-to-test |
rleungx
approved these changes
Jul 15, 2019
nolouch
added a commit
to nolouch/pd
that referenced
this pull request
Jul 15, 2019
* pkg,tools: improve the log message Signed-off-by: nolouch <[email protected]>
nolouch
added a commit
that referenced
this pull request
Jul 15, 2019
* pkg,tools: improve the log message Signed-off-by: nolouch <[email protected]>
nolouch
added a commit
to nolouch/pd
that referenced
this pull request
Jul 15, 2019
* pkg,tools: improve the log message Signed-off-by: nolouch <[email protected]>
youjiali1995
pushed a commit
that referenced
this pull request
Jul 17, 2019
* *:Start swithing to the zap logger (#1422) Signed-off-by: nolouch <[email protected]> * *: log format for schedule, scheduler, syncer, api (#1423) * log format for schedule, scheduler, syncer, api Signed-off-by: rleungx <[email protected]> * pdctl, api: support hex format keys (#1309) pdctl, api: support hex format keys Signed-off-by: disksing <[email protected]> * *: log format for tools, client, pkg, table (#1424) * log format for tools, client, pkg, table, simulator Signed-off-by: rleungx <[email protected]> * *: log format for server (#1431) * *: log format for server Signed-off-by: nolouch <[email protected]> * *: log format for logutil, server/core (#1438) * *: log format for logutil,server/core * *: improve some logs (#1516) * improve some logs Signed-off-by: Ryan Leung <[email protected]> * log: do not add stack to error log (#1532) * pkg, tools: improve the log message (#1636) * pkg,tools: improve the log message Signed-off-by: nolouch <[email protected]> * core: use hex format for region meta key (#1627) Signed-off-by: Ryan Leung <[email protected]>= * address comments Signed-off-by: nolouch <[email protected]> * address comments Signed-off-by: nolouch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: nolouch [email protected]
What problem does this PR solve?
Improve the log message.
What is changed and how it works?
Check List
Tests