Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: fix failpoint enable #1722

Merged
merged 1 commit into from
Sep 3, 2019
Merged

Makefile: fix failpoint enable #1722

merged 1 commit into from
Sep 3, 2019

Conversation

nolouch
Copy link
Contributor

@nolouch nolouch commented Sep 2, 2019

Signed-off-by: nolouch [email protected]

What problem does this PR solve?

❯ make failpoint-enable
# Converting failpoints...
retool: downloading github.com/mgechev/revive
retool: setting version for github.com/mgechev/revive
retool: fatal err: execution error on "git checkout 7773f47324c2bf1c8f7a5500aff2b6c01d3ed73b": chdir /Users/nolouch/csn/program/go/src/github.com/pingcap/pd/.retools/src/github.com/mgechev/revive: no such file or directory
make: *** [failpoint-enable] Error 1

What is changed and how it works?

setup firstly.

Check List

Tests

  • Manual test (add detailed scripts or steps below)
❯ make failpoint-enable
retool: downloading github.com/mgechev/revive
retool: setting version for github.com/mgechev/revive
retool: downloading github.com/dnephin/govet
retool: setting version for github.com/dnephin/govet
retool: downloading github.com/pingcap/failpoint/failpoint-ctl
retool: setting version for github.com/pingcap/failpoint/failpoint-ctl
retool: downloading github.com/go-playground/overalls
retool: setting version for github.com/go-playground/overalls
retool: downloading github.com/golangci/golangci-lint/cmd/golangci-lint
retool: setting version for github.com/golangci/golangci-lint/cmd/golangci-lint
retool: downloading golang.org/x/tools/cmd/goimports
retool: setting version for golang.org/x/tools/cmd/goimports
retool: installing github.com/mgechev/revive
retool: installing github.com/dnephin/govet
retool: installing github.com/pingcap/failpoint/failpoint-ctl
retool: installing github.com/go-playground/overalls
retool: installing github.com/golangci/golangci-lint/cmd/golangci-lint
retool: installing golang.org/x/tools/cmd/goimports
# Converting failpoints...

@CLAassistant
Copy link

CLAassistant commented Sep 2, 2019

CLA assistant check
All committers have signed the CLA.

@rleungx rleungx merged commit a67b5db into tikv:master Sep 3, 2019
Luffbee added a commit that referenced this pull request Sep 9, 2019
* *: unify get store function everywhere (#1671)

Signed-off-by: Ryan Leung <[email protected]>

* remove unnecessary parentheses

*  server: use leader lease to determine tso service validity (#1676)

Signed-off-by: disksing <[email protected]>

* change internal stat values to float64

* add pending operator influence

* add metrics of pending influence

* fix metrics

* fix panic

* adjust pending influence of balanceHotWrite

* change weight of pending influence

* test: fix tests (#1696)

* test: fix region syncer test

Signed-off-by: disksing <[email protected]>

* decrease region rolling window; store pending influence in scheduler

* add config-check flag for pd-server (#1695)

Signed-off-by: cwen0 <[email protected]>

* decrease possiblility transfer hot write leader

* change pending influence weight

* add unstarted op metrics

* add logs for debug

* add log for debug

* add logs for debug

* add logs for debug

* add logs for debug

* add logs for debug

* add logs for debug

* add logs for debug

* Revert "add logs for debug"

This reverts commit e74c7a9.

* add metrics for hotspot operators

* operator: rewrite move region related functions (#1667)

* add metrics for pending operators

* *: support setting endKey for ScanRange (#1700)

Signed-off-by: disksing <[email protected]>

* fix bug

* fix bug

* fix bug

* fix metrics thread-safe bug

* fix logic bug

* *: reduce some unnecessary parameters (#1698)

Signed-off-by: Ryan Leung <[email protected]>

* schedule: Do not send an operator of a region wth a stale epoch (#1659)

* schedule: Do not send an operator of a region wth a stale epoch

Signed-off-by: Shafreeck Sea <[email protected]>

* schedule: check the version changed by the operator self

Signed-off-by: Shafreeck Sea <[email protected]>

* schedule: fix unit test

Signed-off-by: Shafreeck Sea <[email protected]>

* schedule: fix to avoid dispatching a stale opstep

Signed-off-by: Shafreeck Sea <[email protected]>

* dispatch: refactor "ConsumeConfVer() int" to "ExpectConfVerChange() bool"

Signed-off-by: Shafreeck Sea <[email protected]>

* dispatch: fix typo in comment

Signed-off-by: Shafreeck Sea <[email protected]>

* fix typo

Co-Authored-By: Ryan Leung <[email protected]>

* dispatch: fix unittest

Signed-off-by: Shafreeck Sea <[email protected]>

* dispatch: refine format

Signed-off-by: Shafreeck Sea <[email protected]>

* server: fix the dead lock in scatter region (#1706)

Signed-off-by: Ryan Leung <[email protected]>

* add drop time for operator

* use IsDropped to recognize canceled ops

* try to fix trans leader burst

* try to fix trans leader burst

* add zombie influence

* change select src dst strategy; improve op_controller

* change select src strategy

* fix bug

* tools: fix set namespace in pd-ctl (#1701)

Signed-off-by: Ryan Leung <[email protected]>

* tools: fix parse url without http prefix (#1703)

Signed-off-by: Ryan Leung <[email protected]>

* tests: support deadlock detection in make test (#1704)

Signed-off-by: Ryan Leung <[email protected]>

* Makefile: fix failpoint enable (#1722)

Signed-off-by: nolouch <[email protected]>

* checker: fix the issue that a region does not merge to the sibling with smaller size (#1723)

Signed-off-by: disksing <[email protected]>

* tools: balance region simulator (#1708)

* scheduler: do not remove the operator when the step does not finish (#1715)

Signed-off-by: Shafreeck Sea <[email protected]>

* operator: fix the AddLearner config version judgment (#1732)

Signed-off-by: nolouch <[email protected]>

* tools: fix TLS in pd control (#1729)

Signed-off-by: Ryan Leung <[email protected]>

* syncer: support TLS for region syncer (#1728)

Signed-off-by: Ryan Leung <[email protected]>

* schedule: fix a thread-safe bug and improve code (#1719)
Luffbee added a commit that referenced this pull request Sep 11, 2019
* *: unify get store function everywhere (#1671)

Signed-off-by: Ryan Leung <[email protected]>

*  server: use leader lease to determine tso service validity (#1676)

Signed-off-by: disksing <[email protected]>

* test: fix tests (#1696)

* test: fix region syncer test

Signed-off-by: disksing <[email protected]>

* add config-check flag for pd-server (#1695)

Signed-off-by: cwen0 <[email protected]>

* operator: rewrite move region related functions (#1667)

* *: support setting endKey for ScanRange (#1700)

Signed-off-by: disksing <[email protected]>

* *: reduce some unnecessary parameters (#1698)

Signed-off-by: Ryan Leung <[email protected]>

* schedule: Do not send an operator of a region wth a stale epoch (#1659)

* schedule: Do not send an operator of a region wth a stale epoch

Signed-off-by: Shafreeck Sea <[email protected]>

* schedule: check the version changed by the operator self

Signed-off-by: Shafreeck Sea <[email protected]>

* schedule: fix unit test

Signed-off-by: Shafreeck Sea <[email protected]>

* schedule: fix to avoid dispatching a stale opstep

Signed-off-by: Shafreeck Sea <[email protected]>

* dispatch: refactor "ConsumeConfVer() int" to "ExpectConfVerChange() bool"

Signed-off-by: Shafreeck Sea <[email protected]>

* dispatch: fix typo in comment

Signed-off-by: Shafreeck Sea <[email protected]>

* fix typo

Co-Authored-By: Ryan Leung <[email protected]>

* dispatch: fix unittest

Signed-off-by: Shafreeck Sea <[email protected]>

* dispatch: refine format

Signed-off-by: Shafreeck Sea <[email protected]>

* server: fix the dead lock in scatter region (#1706)

Signed-off-by: Ryan Leung <[email protected]>

* tools: fix set namespace in pd-ctl (#1701)

Signed-off-by: Ryan Leung <[email protected]>

* tools: fix parse url without http prefix (#1703)

Signed-off-by: Ryan Leung <[email protected]>

* tests: support deadlock detection in make test (#1704)

Signed-off-by: Ryan Leung <[email protected]>

* Makefile: fix failpoint enable (#1722)

Signed-off-by: nolouch <[email protected]>

* checker: fix the issue that a region does not merge to the sibling with smaller size (#1723)

Signed-off-by: disksing <[email protected]>

* tools: balance region simulator (#1708)

* scheduler: do not remove the operator when the step does not finish (#1715)

Signed-off-by: Shafreeck Sea <[email protected]>

* operator: fix the AddLearner config version judgment (#1732)

Signed-off-by: nolouch <[email protected]>

* tools: fix TLS in pd control (#1729)

Signed-off-by: Ryan Leung <[email protected]>

* syncer: support TLS for region syncer (#1728)

Signed-off-by: Ryan Leung <[email protected]>

* schedule: fix a thread-safe bug and improve code (#1719)

* statistics: fix region flow calculation (#1688)

Signed-off-by: jiyingtk <[email protected]>

* makefile: improve deadlock-enable/disable (#1736)

* api: fix missing keys statistic in region information (#1741)

Signed-off-by: nolouch <[email protected]>

* *: update go version to 1.13 (#1742)

Signed-off-by: disksing <[email protected]>

* coordinator: add the operator cost time in log field (#1748)

Signed-off-by: nolouch <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants