Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: repair test #1792

Merged
merged 2 commits into from
Oct 11, 2019
Merged

test: repair test #1792

merged 2 commits into from
Oct 11, 2019

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Oct 10, 2019

Signed-off-by: lhy1024 [email protected]

What problem does this PR solve?

repair test failed in TestStoreOverloaded and TestStoreOverloadedWithReplace with deadlock-enable.

Check List

Tests

  • Unit test

Signed-off-by: lhy1024 <[email protected]>
@lhy1024 lhy1024 added the component/testing CI testing. label Oct 10, 2019
@lhy1024 lhy1024 requested review from nolouch and rleungx October 10, 2019 11:45
@lhy1024
Copy link
Contributor Author

lhy1024 commented Oct 10, 2019

/run-all-tests

1 similar comment
@lhy1024
Copy link
Contributor Author

lhy1024 commented Oct 10, 2019

/run-all-tests

@codecov-io
Copy link

codecov-io commented Oct 10, 2019

Codecov Report

Merging #1792 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1792      +/-   ##
==========================================
- Coverage   77.47%   77.41%   -0.07%     
==========================================
  Files         163      163              
  Lines       16433    16433              
==========================================
- Hits        12731    12721      -10     
- Misses       2661     2670       +9     
- Partials     1041     1042       +1
Impacted Files Coverage Δ
server/kv/etcd_kv.go 70.12% <0%> (-9.1%) ⬇️
server/schedulers/shuffle_hot_region.go 58.97% <0%> (-6.42%) ⬇️
server/tso/tso.go 80.73% <0%> (-1.84%) ⬇️
server/grpc_service.go 57.04% <0%> (-1.09%) ⬇️
client/client.go 68.6% <0%> (-0.44%) ⬇️
server/cluster.go 84.46% <0%> (+0.25%) ⬆️
server/server.go 82.6% <0%> (+0.37%) ⬆️
server/member/leader.go 77.04% <0%> (+3.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4acaa8c...e49cb2b. Read the comment docs.

server/coordinator_test.go Outdated Show resolved Hide resolved
Signed-off-by: lhy1024 <[email protected]>
@shafreeck
Copy link
Contributor

What is the relation between these test cases with deadlock-enable?

@lhy1024
Copy link
Contributor Author

lhy1024 commented Oct 10, 2019

What is the relation between these test cases with deadlock-enable?

Deadlock detection causes the token to not be acquired properly on a high-load machine, so the test fails

@rleungx rleungx added the status/can-merge Indicates a PR has been approved by a committer. label Oct 11, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Oct 11, 2019

/run-all-tests

@sre-bot sre-bot merged commit 1fbadf8 into tikv:master Oct 11, 2019
lhy1024 added a commit to lhy1024/pd that referenced this pull request Oct 11, 2019
Signed-off-by: lhy1024 <[email protected]>

(cherry picked from commit 1fbadf8)
Signed-off-by: lhy1024 <[email protected]>
lhy1024 added a commit to lhy1024/pd that referenced this pull request Oct 11, 2019
Signed-off-by: lhy1024 <[email protected]>

(cherry picked from commit 1fbadf8)
Signed-off-by: lhy1024 <[email protected]>
@lhy1024 lhy1024 deleted the repair-test branch October 25, 2019 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/testing CI testing. status/can-merge Indicates a PR has been approved by a committer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants