server: fix the race condition of region heartbeats from different regions #2198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regions Signed-off-by: youjiali1995 <[email protected]>
youjiali1995
added
type/bug
|
/run-all-tests |
nolouch
approved these changes
Mar 5, 2020
|
Can we add a test to cover this case? |
Yes. |
Signed-off-by: youjiali1995 <[email protected]>
…li1995/pd into fix-region-heartbeat-race
|
/run-all-tests |
Signed-off-by: youjiali1995 <[email protected]>
…li1995/pd into fix-region-heartbeat-race
|
/merge |
sre-bot
added
the
status/can-merge
|
Your auto merge job has been accepted, waiting for 2197 |
|
@youjiali1995 Please resolve the conflict. |
…n-heartbeat-race Signed-off-by: youjiali1995 <[email protected]>
|
/run-all-tests |
Sorry for the late reply. PTAL again. @rleungx |
|
/merge |
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #2198 +/- ##
=========================================
Coverage ? 76.01%
=========================================
Files ? 196
Lines ? 21080
Branches ? 0
=========================================
Hits ? 16025
Misses ? 3876
Partials ? 1179
Continue to review full report at Codecov.
|
|
cherry pick to release-3.0 failed |
|
cherry pick to release-3.1 failed |
youjiali1995
added a commit
to youjiali1995/pd
that referenced
this pull request
Mar 12, 2020
…ions (tikv#2198) Signed-off-by: youjiali1995 <[email protected]>
youjiali1995
added a commit
that referenced
this pull request
Mar 12, 2020
…ions (#2198) (#2233) Signed-off-by: youjiali1995 <[email protected]>
youjiali1995
added a commit
to youjiali1995/pd
that referenced
this pull request
Mar 12, 2020
…gions (tikv#2198) Signed-off-by: youjiali1995 <[email protected]>
disksing
pushed a commit
that referenced
this pull request
Mar 12, 2020
…gions (#2198) (#2234) Signed-off-by: youjiali1995 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: youjiali1995 [email protected]
What problem does this PR solve?
Fix #2149
What is changed and how it works?
Check the validation of the region heartbeat again before putting it.
Check List
Tests
Code changes
Side effects
Related changes