Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server, client: add down_peer and pending_peer in region response #2429

Merged
merged 4 commits into from
May 20, 2020

Conversation

disksing
Copy link
Contributor

@disksing disksing commented May 19, 2020

What problem does this PR solve?

TiDB needs to identify down and pending peers to first connect to good peer.

What is changed and how it works?

  • update kvproto
  • return down peers and pending peers list
  • update pd client

Check List

Tests

  • Unit test

Side effects

  • Breaking backward compatibility (pd client has interface changed)

Related changes

Release note

  • Add DownPeers and PendingPeers in region response

@disksing disksing added the component/client Client logic. label May 19, 2020
@sre-bot
Copy link
Contributor

sre-bot commented May 19, 2020

@disksing
Copy link
Contributor Author

/rebuild

Signed-off-by: disksing <[email protected]>
disksing added 2 commits May 19, 2020 18:19
Signed-off-by: disksing <[email protected]>
Signed-off-by: disksing <[email protected]>
@disksing disksing requested review from rleungx, nolouch and lhy1024 and removed request for rleungx May 19, 2020 10:36
Copy link
Contributor

@lhy1024 lhy1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhy1024
Copy link
Contributor

lhy1024 commented May 19, 2020

/approve

Copy link
Contributor

@sre-bot sre-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nolouch
Copy link
Contributor

nolouch commented May 20, 2020

/approve

Copy link
Contributor

@sre-bot sre-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nolouch
Copy link
Contributor

nolouch commented May 20, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 20, 2020
@sre-bot
Copy link
Contributor

sre-bot commented May 20, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented May 20, 2020

@disksing merge failed.

@disksing
Copy link
Contributor Author

/merge

2 similar comments
@disksing
Copy link
Contributor Author

/merge

@disksing
Copy link
Contributor Author

/merge

@sre-bot
Copy link
Contributor

sre-bot commented May 20, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented May 20, 2020

@disksing merge failed.

@sre-bot
Copy link
Contributor

sre-bot commented May 20, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented May 20, 2020

@disksing merge failed.

@sre-bot
Copy link
Contributor

sre-bot commented May 20, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented May 20, 2020

@disksing merge failed.

@disksing disksing merged commit 2c251bd into tikv:master May 20, 2020
@disksing disksing deleted the region-stats branch May 20, 2020 08:30
@disksing disksing added the needs-cherry-pick-release-4.0 The PR needs to cherry pick to release-4.0 branch. label May 22, 2020
@disksing
Copy link
Contributor Author

/run-cherry-picker

@disksing
Copy link
Contributor Author

/run-cherry-pick

@sre-bot
Copy link
Contributor

sre-bot commented May 22, 2020

cherry pick to release-4.0 in PR #2443

jebter pushed a commit that referenced this pull request May 25, 2020
) (#2443)

* server: add down_peers and pending_peers in get_region response

Signed-off-by: disksing <[email protected]>

* update pd client

Signed-off-by: disksing <[email protected]>

* minor update

Signed-off-by: disksing <[email protected]>

* minor update

Signed-off-by: disksing <[email protected]>

* fix unstable test TestGetRegionByID (#2435)

Signed-off-by: nolouch <[email protected]>

Co-authored-by: disksing <[email protected]>
Co-authored-by: ShuNing <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/client Client logic. needs-cherry-pick-release-4.0 The PR needs to cherry pick to release-4.0 branch. status/can-merge Indicates a PR has been approved by a committer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants