config: add initial-cluster-token config #2691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: disksing <[email protected]>
Signed-off-by: disksing <[email protected]>
disksing
added
component/config
rleungx
reviewed
Jul 29, 2020
tests/server/server_test.go
Outdated
| @@ -25,6 +25,7 @@ import ( | |||
| "go.uber.org/goleak" | |||
|
|
|||
| // Register schedulers. | |||
| "github.com/pingcap/pd/v4/server/config" | |||
There was a problem hiding this comment.
The comment is used to describe line 29.
Signed-off-by: disksing <[email protected]>
ti-srebot
approved these changes
Jul 30, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
|
@disksing merge failed. |
|
/run-test |
|
/build |
This was referenced Aug 4, 2020
disksing
added
the
needs-cherry-pick-release-4.0
|
/run-cherry-picker |
ti-srebot
pushed a commit
to ti-srebot/pd
that referenced
this pull request
Sep 8, 2020
Signed-off-by: ti-srebot <[email protected]>
|
cherry pick to release-4.0 in PR #2922 |
disksing
pushed a commit
that referenced
this pull request
Sep 8, 2020
Signed-off-by: disksing <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix #2689
What is changed and how it works?
Add config, pass it to etcd.
Check List
Tests
Code changes
Related changes
pingcap/docs/pingcap/docs-cn:Release note
initial-cluster-tokenconfiguration to avoid different clusters communicate during bootstrap