-
Notifications
You must be signed in to change notification settings - Fork 727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apiutil: refine the log errs in apiutil #2722
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JmPotato <[email protected]>
@ZenoTan PTAL! |
nolouch
reviewed
Aug 5, 2020
Signed-off-by: JmPotato <[email protected]>
Signed-off-by: JmPotato <[email protected]>
rleungx
approved these changes
Aug 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ti-srebot
approved these changes
Aug 19, 2020
/run-all-tests |
howardlau1999
pushed a commit
to howardlau1999/pd
that referenced
this pull request
Aug 20, 2020
Signed-off-by: JmPotato <[email protected]>
ZenoTan
pushed a commit
to ZenoTan/pd
that referenced
this pull request
Aug 24, 2020
Signed-off-by: JmPotato <[email protected]> Signed-off-by: ZenoTan <[email protected]>
jyz0309
pushed a commit
to jyz0309/pd
that referenced
this pull request
Aug 24, 2020
Signed-off-by: JmPotato <[email protected]>
jyz0309
pushed a commit
to jyz0309/pd
that referenced
this pull request
Aug 24, 2020
Signed-off-by: JmPotato <[email protected]>
rleungx
added
needs-cherry-pick-release-4.0
The PR needs to cherry pick to release-4.0 branch.
labels
Sep 7, 2020
ti-srebot
pushed a commit
to ti-srebot/pd
that referenced
this pull request
Sep 7, 2020
Signed-off-by: ti-srebot <[email protected]>
cherry pick to release-4.0 in PR #2912 |
rleungx
pushed a commit
to ti-srebot/pd
that referenced
this pull request
Sep 7, 2020
Signed-off-by: Ryan Leung <[email protected]>
ti-srebot
added a commit
that referenced
this pull request
Sep 7, 2020
Signed-off-by: Ryan Leung <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component/api
HTTP API.
component/log
Log.
contribution
This PR is from a community contributor.
needs-cherry-pick-release-4.0
The PR needs to cherry pick to release-4.0 branch.
require-LGT1
Indicates that the PR requires an LGTM.
status/LGT1
Indicates that a PR has LGTM 1.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: JmPotato [email protected]
What problem does this PR solve?
To solve #2704
What is changed and how it works?
Check List
Tests
Release note