Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apiutil: refine the log errs in apiutil #2722

Merged
merged 4 commits into from
Aug 19, 2020
Merged

apiutil: refine the log errs in apiutil #2722

merged 4 commits into from
Aug 19, 2020

Conversation

JmPotato
Copy link
Member

@JmPotato JmPotato commented Aug 5, 2020

Signed-off-by: JmPotato [email protected]

What problem does this PR solve?

To solve #2704

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test

Release note

  • No release note

@JmPotato JmPotato requested review from nolouch and rleungx August 5, 2020 02:34
@ti-srebot ti-srebot added the contribution This PR is from a community contributor. label Aug 5, 2020
@JmPotato
Copy link
Member Author

JmPotato commented Aug 5, 2020

@ZenoTan PTAL!

Signed-off-by: JmPotato <[email protected]>
@JmPotato JmPotato added the require-LGT1 Indicates that the PR requires an LGTM. label Aug 19, 2020
@JmPotato
Copy link
Member Author

@nolouch @rleungx PTAL

@JmPotato JmPotato requested a review from nolouch August 19, 2020 06:49
Copy link
Member

@rleungx rleungx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 19, 2020
@JmPotato
Copy link
Member Author

/run-all-tests

@JmPotato JmPotato merged commit a6cb51b into master Aug 19, 2020
@JmPotato JmPotato deleted the apiutil_err branch August 19, 2020 09:28
howardlau1999 pushed a commit to howardlau1999/pd that referenced this pull request Aug 20, 2020
ZenoTan pushed a commit to ZenoTan/pd that referenced this pull request Aug 24, 2020
jyz0309 pushed a commit to jyz0309/pd that referenced this pull request Aug 24, 2020
jyz0309 pushed a commit to jyz0309/pd that referenced this pull request Aug 24, 2020
@rleungx rleungx added needs-cherry-pick-release-4.0 The PR needs to cherry pick to release-4.0 branch. labels Sep 7, 2020
ti-srebot pushed a commit to ti-srebot/pd that referenced this pull request Sep 7, 2020
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #2912

rleungx pushed a commit to ti-srebot/pd that referenced this pull request Sep 7, 2020
ti-srebot added a commit that referenced this pull request Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/api HTTP API. component/log Log. contribution This PR is from a community contributor. needs-cherry-pick-release-4.0 The PR needs to cherry pick to release-4.0 branch. require-LGT1 Indicates that the PR requires an LGTM. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants