Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: add service gc safepoint commands (#2797) #2813

Merged
merged 3 commits into from
Aug 21, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #2797 to release-4.0


What problem does this PR solve?

Add service gc safepoint commands. Resolve #2786

Tests

  • Unit test

Code changes

Related changes

Release note

  • Add service gc safepoit commands

@ti-srebot ti-srebot added component/api HTTP API. component/pd-ctl status/LGT2 Indicates that a PR has LGTM 2. labels Aug 21, 2020
@ti-srebot ti-srebot requested review from disksing and rleungx August 21, 2020 05:48
@ti-srebot ti-srebot added this to the v4.0.6 milestone Aug 21, 2020
@ti-srebot
Copy link
Contributor Author

@overvenus please accept the invitation then you can push to the cherry-pick pull requests.
https://github.com/ti-srebot/pd/invitations

Signed-off-by: Neil Shen <[email protected]>
@overvenus
Copy link
Member

/run-unit-test

@codecov
Copy link

codecov bot commented Aug 21, 2020

Codecov Report

Merging #2813 into release-4.0 will increase coverage by 0.17%.
The diff coverage is 79.09%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-4.0    #2813      +/-   ##
===============================================
+ Coverage        77.16%   77.34%   +0.17%     
===============================================
  Files              204      208       +4     
  Lines            21940    22765     +825     
===============================================
+ Hits             16931    17608     +677     
- Misses            3724     3827     +103     
- Partials          1285     1330      +45     
Impacted Files Coverage Δ
client/base_client.go 90.60% <ø> (ø)
client/metrics.go 100.00% <ø> (ø)
pkg/apiutil/apiutil.go 67.34% <ø> (ø)
pkg/apiutil/serverapi/middleware.go 73.07% <ø> (ø)
pkg/cache/cache.go 0.00% <ø> (ø)
pkg/cache/fifo.go 100.00% <ø> (ø)
pkg/cache/lru.go 80.35% <ø> (ø)
pkg/cache/two_queue.go 66.66% <ø> (ø)
pkg/codec/codec.go 78.57% <ø> (ø)
pkg/component/manager.go 81.01% <ø> (ø)
... and 206 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d566cb...6dc2da8. Read the comment docs.

Copy link
Member

@rleungx rleungx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT1 Indicates that a PR has LGTM 1. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Aug 21, 2020
@disksing
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 21, 2020
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@disksing
Copy link
Contributor

/merge

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot merged commit c5a013a into tikv:release-4.0 Aug 21, 2020
@disksing disksing deleted the release-4.0-d40341ce7b1f branch August 21, 2020 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/api HTTP API. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants