server: Auto fix gc_worker's service safepoint for upgraded clusters (#3371) #3392
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #3371 to release-5.0-rc
You can switch your code base to this Pull Request by using git-extras:
# In pd repo: git pr https://github.com/tikv/pd/pull/3392
After apply modifications, you can push your change to this PR via:
Signed-off-by: MyonKeminta [email protected]
What problem does this PR solve?
Fixes #3366
Though we did a fix in PR #3146 , there's still a problem for clusters upgraded from older version, where the gc_worker's service safepoint may be invalid or missing and there are other service safepoints in the cluster.
What is changed and how it works?
Checks if "gc_worker"'s service safepoint exist and has a infinite TTL every time loading safepoints, and tries to fix it if possible.
Check List
Tests
Code changes
Side effects
Related changes
Release note