Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: make flow-round-by-digit compatible with trace-region-flow #3747

Merged
merged 3 commits into from
Jun 4, 2021

Conversation

nolouch
Copy link
Contributor

@nolouch nolouch commented Jun 4, 2021

Signed-off-by: nolouch [email protected]

What problem does this PR solve?

deprecate trace-region-flow

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    situation 1
### old server
➜  pd git:(remove-trace-flow) ✗ ./bin/pd-ctl config set trace-region-flow false
Success!
➜  pd git:(remove-trace-flow) ✗ ./bin/pd-ctl config show all |grep flow        
"trace-region-flow": "false"

### start new binary
➜  pd git:(remove-trace-flow) ✗ ./bin/pd-ctl config show all |grep flow
"flow-round-by-digit": 9223372036854775807
➜  pd git:(remove-trace-flow) ✗ ./bin/pd-ctl config set flow-round-by-digit 9
Success!
➜  pd git:(remove-trace-flow) ✗ ./bin/pd-ctl config show all |grep flow      
"flow-round-by-digit": 9
### restart new binary
➜  pd git:(remove-trace-flow) ✗ ./bin/pd-ctl config show all |grep flow      
"flow-round-by-digit": 9

situation 2

### old server
➜  pd git:(remove-trace-flow) ./bin/pd-ctl config show all |grep flow
    "trace-region-flow": "true"
### restart with new binary
➜  pd git:(remove-trace-flow) ./bin/pd-ctl config show all |grep flow
    "flow-round-by-digit": 3
### restart with new binary
➜  pd git:(remove-trace-flow) ./bin/pd-ctl config show all |grep flow
    "flow-round-by-digit": 3

Release note

 Deprecate  `trace-region-flow`, and use new config `flow-round-by-digit`

@ti-chi-bot ti-chi-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jun 4, 2021
@ti-chi-bot ti-chi-bot requested review from disksing and rleungx June 4, 2021 10:52
Signed-off-by: nolouch <[email protected]>
@nolouch nolouch added the priority/P0 The issue has P0 priority. label Jun 4, 2021
Signed-off-by: nolouch <[email protected]>
@codecov
Copy link

codecov bot commented Jun 4, 2021

Codecov Report

Merging #3747 (f387675) into master (a9e629d) will increase coverage by 0.09%.
The diff coverage is 70.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3747      +/-   ##
==========================================
+ Coverage   75.10%   75.20%   +0.09%     
==========================================
  Files         244      244              
  Lines       24477    24492      +15     
==========================================
+ Hits        18384    18418      +34     
+ Misses       4472     4460      -12     
+ Partials     1621     1614       -7     
Flag Coverage Δ
unittests 75.20% <70.58%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/config/config.go 74.84% <64.28%> (-0.32%) ⬇️
server/cluster/cluster.go 82.76% <100.00%> (ø)
server/config/persist_options.go 91.40% <100.00%> (+0.03%) ⬆️
server/schedulers/utils.go 93.75% <0.00%> (-1.05%) ⬇️
pkg/btree/btree.go 85.30% <0.00%> (-0.97%) ⬇️
server/schedule/operator/step.go 67.77% <0.00%> (-0.67%) ⬇️
server/grpc_service.go 48.57% <0.00%> (-0.23%) ⬇️
server/tso/allocator_manager.go 79.13% <0.00%> (+0.16%) ⬆️
server/server.go 72.07% <0.00%> (+0.75%) ⬆️
server/tso/tso.go 74.15% <0.00%> (+4.49%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9e629d...f387675. Read the comment docs.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 4, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 4, 2021
@nolouch
Copy link
Contributor Author

nolouch commented Jun 4, 2021

/merge

@ti-chi-bot
Copy link
Member

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f387675

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 4, 2021
@ti-chi-bot ti-chi-bot merged commit 611e827 into tikv:master Jun 4, 2021
@nolouch nolouch deleted the remove-trace-flow branch June 4, 2021 14:07
bufferflies pushed a commit to bufferflies/pd that referenced this pull request Jul 9, 2021
)

* *: make flow-round-by-digit compatible with trace-region-flow

Signed-off-by: nolouch <[email protected]>

* fix test

Signed-off-by: nolouch <[email protected]>

* fix test

Signed-off-by: nolouch <[email protected]>
bufferflies pushed a commit to bufferflies/pd that referenced this pull request Jul 9, 2021
)

* *: make flow-round-by-digit compatible with trace-region-flow

Signed-off-by: nolouch <[email protected]>

* fix test

Signed-off-by: nolouch <[email protected]>

* fix test

Signed-off-by: nolouch <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/P0 The issue has P0 priority. release-note Denotes a PR that will be considered when it comes time to generate release notes. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants