Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: add qps metrics and remove unnecessary metrics #3954

Merged
merged 5 commits into from
Aug 5, 2021

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Aug 4, 2021

Signed-off-by: lhy1024 [email protected]

What problem does this PR solve?

add Store write qps and Store read qps

remove Total written bytes on hot peer Regions and Total read bytes on hot peer Regions

image

image

Check List

Tests

  • No code

Release note

None.

Signed-off-by: lhy1024 <[email protected]>
@lhy1024 lhy1024 requested review from Yisaer and HunDunDM August 4, 2021 14:33
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 4, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bufferflies
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Aug 4, 2021
@lhy1024 lhy1024 added component/metrics Metrics. priority/P1 The issue has P1 priority. labels Aug 4, 2021
@codecov
Copy link

codecov bot commented Aug 4, 2021

Codecov Report

Merging #3954 (2c198bc) into master (9874714) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3954      +/-   ##
==========================================
- Coverage   74.76%   74.74%   -0.02%     
==========================================
  Files         246      246              
  Lines       25131    25131              
==========================================
- Hits        18789    18784       -5     
+ Misses       4696     4695       -1     
- Partials     1646     1652       +6     
Flag Coverage Δ
unittests 74.74% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/kv/etcd_kv.go 72.46% <0.00%> (-7.25%) ⬇️
server/tso/local_allocator.go 71.62% <0.00%> (-6.76%) ⬇️
pkg/dashboard/adapter/manager.go 78.72% <0.00%> (-4.26%) ⬇️
server/statistics/hot_cache_task.go 75.00% <0.00%> (-4.17%) ⬇️
server/tso/tso.go 62.43% <0.00%> (-2.21%) ⬇️
server/election/lease.go 94.91% <0.00%> (-1.70%) ⬇️
server/schedule/operator/step.go 68.10% <0.00%> (-1.67%) ⬇️
server/encryptionkm/key_manager.go 71.78% <0.00%> (-1.66%) ⬇️
server/member/member.go 65.24% <0.00%> (-1.61%) ⬇️
server/grpc_service.go 47.00% <0.00%> (-0.68%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9874714...2c198bc. Read the comment docs.

metrics/grafana/pd.json Outdated Show resolved Hide resolved
metrics/grafana/pd.json Outdated Show resolved Hide resolved
Copy link
Contributor

@Yisaer Yisaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will give LGTM when you address the comment

Copy link
Contributor

@bufferflies bufferflies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 5, 2021
Signed-off-by: lhy1024 <[email protected]>
@lhy1024
Copy link
Contributor Author

lhy1024 commented Aug 5, 2021

@rleungx @Yisaer PTAL

Signed-off-by: lhy1024 <[email protected]>
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 5, 2021
lhy1024 added 2 commits August 5, 2021 14:47
Signed-off-by: lhy1024 <[email protected]>
Signed-off-by: lhy1024 <[email protected]>
@lhy1024
Copy link
Contributor Author

lhy1024 commented Aug 5, 2021

/merge

@ti-chi-bot
Copy link
Member

@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2c198bc

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 5, 2021
@ti-chi-bot ti-chi-bot merged commit 371edbd into tikv:master Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/metrics Metrics. priority/P1 The issue has P1 priority. release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants