Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: use compatible config after upgrading for hot-region #3981

Merged
merged 5 commits into from
Aug 13, 2021

Conversation

HunDunDM
Copy link
Member

Signed-off-by: HunDunDM [email protected]

What problem does this PR solve?

What is changed and how it works?

scheduler: use compatible config after upgrading for hot-region

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release note

None

@HunDunDM HunDunDM added component/scheduler Scheduler logic. needs-cherry-pick-release-5.2 Type: Need cherry pick to release-5.2 labels Aug 12, 2021
@HunDunDM HunDunDM requested a review from lhy1024 August 12, 2021 11:44
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 12, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Yisaer
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Aug 12, 2021
@codecov
Copy link

codecov bot commented Aug 12, 2021

Codecov Report

Merging #3981 (f5eab42) into master (2b2d886) will increase coverage by 0.09%.
The diff coverage is 76.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3981      +/-   ##
==========================================
+ Coverage   74.60%   74.70%   +0.09%     
==========================================
  Files         250      250              
  Lines       25505    25511       +6     
==========================================
+ Hits        19028    19057      +29     
+ Misses       4785     4769      -16     
+ Partials     1692     1685       -7     
Flag Coverage Δ
unittests 74.70% <76.92%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/schedulers/hot_region.go 83.71% <57.14%> (-0.17%) ⬇️
server/schedulers/hot_region_config.go 89.39% <100.00%> (+0.08%) ⬆️
pkg/tempurl/tempurl.go 45.00% <0.00%> (-15.00%) ⬇️
pkg/etcdutil/etcdutil.go 84.70% <0.00%> (-3.53%) ⬇️
server/member/member.go 66.84% <0.00%> (-1.61%) ⬇️
server/grpc_service.go 47.23% <0.00%> (-0.46%) ⬇️
client/client.go 71.82% <0.00%> (-0.14%) ⬇️
server/server.go 72.18% <0.00%> (+0.30%) ⬆️
server/schedule/operator/builder.go 88.39% <0.00%> (+0.40%) ⬆️
server/tso/allocator_manager.go 68.28% <0.00%> (+0.66%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b2d886...f5eab42. Read the comment docs.

Signed-off-by: HunDunDM <[email protected]>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 12, 2021
Copy link
Contributor

@Yisaer Yisaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

basically lgtm

server/schedulers/hot_region_config.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 13, 2021
Signed-off-by: HunDunDM <[email protected]>
@lhy1024
Copy link
Contributor

lhy1024 commented Aug 13, 2021

/merge

@ti-chi-bot
Copy link
Member

@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0017975

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 13, 2021
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #3986.

@HunDunDM HunDunDM deleted the hotsche-compatible-cfg branch August 13, 2021 07:12
ti-chi-bot added a commit that referenced this pull request Aug 13, 2021
… (#3986)

* scheduler: use compatible config after upgrading for hot-region-scheduler

Signed-off-by: HunDunDM <[email protected]>

* add unit test

Signed-off-by: HunDunDM <[email protected]>

* add unit test

Signed-off-by: HunDunDM <[email protected]>

* address comment

Signed-off-by: HunDunDM <[email protected]>

Co-authored-by: HunDunDM <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/scheduler Scheduler logic. needs-cherry-pick-release-5.2 Type: Need cherry pick to release-5.2 release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants