-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scheduler: use compatible config after upgrading for hot-region #3981
Conversation
…uler Signed-off-by: HunDunDM <[email protected]>
Signed-off-by: HunDunDM <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## master #3981 +/- ##
==========================================
+ Coverage 74.60% 74.70% +0.09%
==========================================
Files 250 250
Lines 25505 25511 +6
==========================================
+ Hits 19028 19057 +29
+ Misses 4785 4769 -16
+ Partials 1692 1685 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: HunDunDM <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
basically lgtm
Signed-off-by: HunDunDM <[email protected]>
/merge |
@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 0017975
|
In response to a cherrypick label: new pull request created: #3986. |
… (#3986) * scheduler: use compatible config after upgrading for hot-region-scheduler Signed-off-by: HunDunDM <[email protected]> * add unit test Signed-off-by: HunDunDM <[email protected]> * add unit test Signed-off-by: HunDunDM <[email protected]> * address comment Signed-off-by: HunDunDM <[email protected]> Co-authored-by: HunDunDM <[email protected]>
Signed-off-by: HunDunDM [email protected]
What problem does this PR solve?
What is changed and how it works?
scheduler: use compatible config after upgrading for hot-region
Check List
Tests
Code changes
Side effects
Related changes
Release note