scheduler: adjust hot region config when pd-ctl return #3982

lhy1024 · 2021-08-12T13:22:27Z

Signed-off-by: lhy1024 [email protected]

What problem does this PR solve?

adjust hot region config when pd-ctl return，ensure that the return result of pd-ctl is consistent with the actual running scheduler

What is changed and how it works?

Check List

Tests

Unit test

Release note

None.

Signed-off-by: lhy1024 <[email protected]>

ti-chi-bot · 2021-08-12T13:22:28Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

HunDunDM
Yisaer

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Yisaer

rest lgtm

server/schedulers/hot_region_config.go

Signed-off-by: lhy1024 <[email protected]>

codecov · 2021-08-13T07:07:49Z

Codecov Report

Merging #3982 (6012338) into master (e137de4) will increase coverage by 0.09%.
The diff coverage is 96.36%.

@@            Coverage Diff             @@
##           master    #3982      +/-   ##
==========================================
+ Coverage   74.67%   74.76%   +0.09%     
==========================================
  Files         250      250              
  Lines       25511    25541      +30     
==========================================
+ Hits        19051    19097      +46     
+ Misses       4774     4765       -9     
+ Partials     1686     1679       -7

Flag	Coverage Δ
unittests	`74.76% <96.36%> (+0.09%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
server/schedulers/hot_region.go	`83.10% <75.00%> (-0.62%)`	⬇️
pkg/mock/mockcluster/mockcluster.go	`95.26% <100.00%> (+0.01%)`	⬆️
server/schedulers/hot_region_config.go	`92.00% <100.00%> (+2.60%)`	⬆️
tests/pdctl/helper.go	`100.00% <100.00%> (ø)`
server/id/id.go	`76.19% <0.00%> (-4.77%)`	⬇️
server/member/member.go	`63.10% <0.00%> (-3.75%)`	⬇️
server/schedule/operator/step.go	`68.10% <0.00%> (-1.00%)`	⬇️
pkg/btree/btree.go	`85.78% <0.00%> (-0.97%)`	⬇️
client/base_client.go	`82.29% <0.00%> (-0.53%)`	⬇️
server/cluster/cluster.go	`82.33% <0.00%> (-0.36%)`	⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e137de4...6012338. Read the comment docs.

server/schedulers/hot_region.go

server/schedulers/hot_region_config.go

tests/pdctl/helper.go

server/schedulers/hot_region_config.go

Signed-off-by: lhy1024 <[email protected]>

server/schedulers/hot_region.go

server/schedulers/hot_region_config.go

Signed-off-by: lhy1024 <[email protected]>

Yisaer

/merge

ti-chi-bot · 2021-08-16T06:39:28Z

@Yisaer: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

lhy1024 · 2021-08-16T07:49:21Z

/rebuild

nolouch · 2021-08-16T08:13:10Z

/merge

ti-chi-bot · 2021-08-16T08:13:11Z

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2021-08-16T08:13:12Z

This pull request has been accepted and is ready to merge.

Commit hash: 6012338

* adjust config when pd-ctl return Signed-off-by: lhy1024 <[email protected]> * address comments Signed-off-by: lhy1024 <[email protected]> * address comments Signed-off-by: lhy1024 <[email protected]> * address comments Signed-off-by: lhy1024 <[email protected]> * address comment Signed-off-by: lhy1024 <[email protected]> * address comment Signed-off-by: lhy1024 <[email protected]> * address comment Signed-off-by: lhy1024 <[email protected]> Co-authored-by: 混沌DM <[email protected]>

ti-chi-bot · 2021-08-16T08:14:35Z

In response to a cherrypick label: new pull request created: #3992.

* adjust config when pd-ctl return Signed-off-by: lhy1024 <[email protected]> * address comments Signed-off-by: lhy1024 <[email protected]> * address comments Signed-off-by: lhy1024 <[email protected]> * address comments Signed-off-by: lhy1024 <[email protected]> * address comment Signed-off-by: lhy1024 <[email protected]> * address comment Signed-off-by: lhy1024 <[email protected]> * address comment Signed-off-by: lhy1024 <[email protected]> Co-authored-by: 混沌DM <[email protected]> Co-authored-by: lhy1024 <[email protected]> Co-authored-by: 混沌DM <[email protected]>

adjust config when pd-ctl return

c03ee03

Signed-off-by: lhy1024 <[email protected]>

lhy1024 added component/scheduler Scheduler logic. needs-cherry-pick-release-5.2 Type: Need cherry pick to release-5.2 labels Aug 12, 2021

lhy1024 requested review from Yisaer and HunDunDM August 12, 2021 13:22

ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Aug 12, 2021

Yisaer reviewed Aug 13, 2021

View reviewed changes

server/schedulers/hot_region_config.go Outdated Show resolved Hide resolved

Yisaer approved these changes Aug 13, 2021

View reviewed changes

ti-chi-bot added status/LGT1 Indicates that a PR has LGTM 1. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 13, 2021

Merge branch 'master' of github.com:tikv/pd into pd-ctl-return

a79d623

Signed-off-by: lhy1024 <[email protected]>

ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 13, 2021

rleungx reviewed Aug 13, 2021

View reviewed changes

HunDunDM reviewed Aug 13, 2021

View reviewed changes

tests/pdctl/helper.go Show resolved Hide resolved

server/schedulers/hot_region_config.go Show resolved Hide resolved

server/schedulers/hot_region_config.go Outdated Show resolved Hide resolved

server/schedulers/hot_region_config.go Outdated Show resolved Hide resolved

lhy1024 added 3 commits August 13, 2021 21:23

address comments

e03319f

Signed-off-by: lhy1024 <[email protected]>

address comments

f3878ec

Signed-off-by: lhy1024 <[email protected]>

address comments

d5d5764

Signed-off-by: lhy1024 <[email protected]>

rleungx reviewed Aug 16, 2021

View reviewed changes

server/schedulers/hot_region.go Outdated Show resolved Hide resolved

server/schedulers/hot_region_config.go Outdated Show resolved Hide resolved

server/schedulers/hot_region_config.go Outdated Show resolved Hide resolved

lhy1024 added 2 commits August 16, 2021 13:17

address comment

8f97efe

Signed-off-by: lhy1024 <[email protected]>

address comment

e984d3e

Signed-off-by: lhy1024 <[email protected]>

HunDunDM approved these changes Aug 16, 2021

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 16, 2021

address comment

103b357

Signed-off-by: lhy1024 <[email protected]>

rleungx approved these changes Aug 16, 2021

View reviewed changes

Yisaer reviewed Aug 16, 2021

View reviewed changes

Merge branch 'master' into pd-ctl-return

6012338

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 16, 2021

ti-chi-bot merged commit ab0125b into tikv:master Aug 16, 2021

ti-chi-bot mentioned this pull request Aug 16, 2021

scheduler: adjust hot region config when pd-ctl return (#3982) #3992

Merged

lhy1024 mentioned this pull request Aug 20, 2021

Adjustable Priority Multidimensional Hot Scheduler Tasklist #3869

Closed

28 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

scheduler: adjust hot region config when pd-ctl return #3982

scheduler: adjust hot region config when pd-ctl return #3982

lhy1024 commented Aug 12, 2021

ti-chi-bot commented Aug 12, 2021 •

edited

Loading

Yisaer left a comment

codecov bot commented Aug 13, 2021 •

edited

Loading

Yisaer left a comment

ti-chi-bot commented Aug 16, 2021

lhy1024 commented Aug 16, 2021

nolouch commented Aug 16, 2021

ti-chi-bot commented Aug 16, 2021

ti-chi-bot commented Aug 16, 2021

ti-chi-bot commented Aug 16, 2021

scheduler: adjust hot region config when pd-ctl return #3982

scheduler: adjust hot region config when pd-ctl return #3982

Conversation

lhy1024 commented Aug 12, 2021

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

ti-chi-bot commented Aug 12, 2021 • edited Loading

Yisaer left a comment

Choose a reason for hiding this comment

codecov bot commented Aug 13, 2021 • edited Loading

Codecov Report

Yisaer left a comment

Choose a reason for hiding this comment

ti-chi-bot commented Aug 16, 2021

lhy1024 commented Aug 16, 2021

nolouch commented Aug 16, 2021

ti-chi-bot commented Aug 16, 2021

ti-chi-bot commented Aug 16, 2021

ti-chi-bot commented Aug 16, 2021

ti-chi-bot commented Aug 12, 2021 •

edited

Loading

codecov bot commented Aug 13, 2021 •

edited

Loading