-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makefile: test the TSO without compiling the dashboard #4441
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
d297ebd
to
48b08f8
Compare
48b08f8
to
f0f57af
Compare
Codecov Report
@@ Coverage Diff @@
## master #4441 +/- ##
=======================================
Coverage 74.81% 74.82%
=======================================
Files 263 263
Lines 27678 27678
=======================================
+ Hits 20707 20709 +2
+ Misses 5124 5123 -1
+ Partials 1847 1846 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: JmPotato <[email protected]>
f0f57af
to
4c30d93
Compare
Signed-off-by: JmPotato <[email protected]>
/run-unit-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/merge |
1 similar comment
/merge |
@nolouch: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 28d06c9
|
1 similar comment
This pull request has been accepted and is ready to merge. Commit hash: 28d06c9
|
Signed-off-by: JmPotato [email protected]
What problem does this PR solve?
There is no need to compile the dashboard before doing the TSO tests. So we should remove it.
What is changed and how it works?
Test the TSO without compiling the dashboard.
Check List
Tests
Release note