Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: test the TSO without compiling the dashboard #4441

Merged
merged 3 commits into from
Dec 9, 2021

Conversation

JmPotato
Copy link
Member

@JmPotato JmPotato commented Dec 8, 2021

Signed-off-by: JmPotato [email protected]

What problem does this PR solve?

There is no need to compile the dashboard before doing the TSO tests. So we should remove it.

What is changed and how it works?

Test the TSO without compiling the dashboard.

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

@JmPotato JmPotato added component/testing CI testing. require-LGT1 Indicates that the PR requires an LGTM. component/tso Timestamp Oracle. labels Dec 8, 2021
@JmPotato JmPotato requested a review from rleungx December 8, 2021 13:36
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 8, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/invalid-commit-message release-note-none Denotes a PR that doesn't merit a release note. labels Dec 8, 2021
@JmPotato JmPotato force-pushed the tso_test_without_dashboard branch from d297ebd to 48b08f8 Compare December 8, 2021 13:37
@JmPotato JmPotato force-pushed the tso_test_without_dashboard branch from 48b08f8 to f0f57af Compare December 8, 2021 13:42
@codecov
Copy link

codecov bot commented Dec 8, 2021

Codecov Report

Merging #4441 (28d06c9) into master (055b433) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4441   +/-   ##
=======================================
  Coverage   74.81%   74.82%           
=======================================
  Files         263      263           
  Lines       27678    27678           
=======================================
+ Hits        20707    20709    +2     
+ Misses       5124     5123    -1     
+ Partials     1847     1846    -1     
Flag Coverage Δ
unittests 74.82% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/errs/errs.go 75.00% <0.00%> (-25.00%) ⬇️
pkg/tempurl/tempurl.go 60.00% <0.00%> (-10.00%) ⬇️
server/tso/local_allocator.go 64.86% <0.00%> (-6.76%) ⬇️
pkg/etcdutil/etcdutil.go 82.35% <0.00%> (-2.36%) ⬇️
server/member/member.go 63.10% <0.00%> (-2.14%) ⬇️
server/server.go 72.01% <0.00%> (-1.18%) ⬇️
server/tso/tso.go 64.77% <0.00%> (-1.14%) ⬇️
server/core/storage.go 68.56% <0.00%> (-0.76%) ⬇️
server/tso/allocator_manager.go 62.83% <0.00%> (-0.67%) ⬇️
server/cluster/cluster.go 82.56% <0.00%> (-0.35%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 055b433...28d06c9. Read the comment docs.

@JmPotato JmPotato force-pushed the tso_test_without_dashboard branch from f0f57af to 4c30d93 Compare December 8, 2021 13:55
@JmPotato
Copy link
Member Author

JmPotato commented Dec 9, 2021

/run-unit-test

Copy link
Contributor

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 9, 2021
@nolouch
Copy link
Contributor

nolouch commented Dec 9, 2021

/merge

1 similar comment
@JmPotato
Copy link
Member Author

JmPotato commented Dec 9, 2021

/merge

@ti-chi-bot
Copy link
Member

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 28d06c9

1 similar comment
@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 28d06c9

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 9, 2021
@ti-chi-bot ti-chi-bot merged commit b017ec5 into tikv:master Dec 9, 2021
@JmPotato JmPotato deleted the tso_test_without_dashboard branch December 9, 2021 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/testing CI testing. component/tso Timestamp Oracle. release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants