Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: fix the display value of the log level #4519

Merged
merged 1 commit into from
Dec 29, 2021

Conversation

nolouch
Copy link
Contributor

@nolouch nolouch commented Dec 29, 2021

Signed-off-by: nolouch [email protected]

What problem does this PR solve?

close #4518
image

What is changed and how it works?

assign default value

Check List

Tests

  • Unit test
  • Integration test
    image

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 29, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HunDunDM
  • bufferflies

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Dec 29, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 29, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 29, 2021
@HunDunDM
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

@HunDunDM: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2f8f947

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 29, 2021
@nolouch
Copy link
Contributor Author

nolouch commented Dec 29, 2021

/run-unit-tests

@codecov
Copy link

codecov bot commented Dec 29, 2021

Codecov Report

Merging #4519 (2f8f947) into master (35a02c6) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4519      +/-   ##
==========================================
+ Coverage   74.80%   74.83%   +0.03%     
==========================================
  Files         264      264              
  Lines       27933    27933              
==========================================
+ Hits        20896    20905       +9     
+ Misses       5164     5157       -7     
+ Partials     1873     1871       -2     
Flag Coverage Δ
unittests 74.83% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/config/config.go 77.89% <100.00%> (ø)
pkg/tempurl/tempurl.go 45.00% <0.00%> (-15.00%) ⬇️
server/kv/etcd_kv.go 69.56% <0.00%> (-10.15%) ⬇️
server/id/id.go 76.19% <0.00%> (-4.77%) ⬇️
server/region_syncer/client.go 79.68% <0.00%> (-3.91%) ⬇️
server/member/member.go 63.10% <0.00%> (-1.61%) ⬇️
server/config/persist_options.go 91.66% <0.00%> (-0.76%) ⬇️
server/tso/allocator_manager.go 64.89% <0.00%> (-0.50%) ⬇️
server/server.go 72.23% <0.00%> (+0.29%) ⬆️
server/grpc_service.go 52.17% <0.00%> (+0.38%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35a02c6...2f8f947. Read the comment docs.

@ti-chi-bot ti-chi-bot merged commit 53ca795 into tikv:master Dec 29, 2021
@nolouch nolouch deleted the fix-log branch December 29, 2021 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default log level show as empty
5 participants