dr-ausosync: report min resolved ts

[lhy1024]

Signed-off-by: lhy1024 [email protected]

What problem does this PR solve?

Issue Number: ref #4686

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)

Release note

dr-ausosync: report min resolved ts 

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• disksing
• nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[codecov]

Codecov Report

Merging #4716 (5d6c960) into master (7e26092) will decrease coverage by 0.09%.
The diff coverage is 64.48%.

❗ Current head 5d6c960 differs from pull request most recent head 3f9c788. Consider uploading reports for the commit 3f9c788 to get more accurate results

@@            Coverage Diff             @@
##           master    #4716      +/-   ##
==========================================
- Coverage   75.09%   75.00%   -0.10%     
==========================================
  Files         284      287       +3     
  Lines       28022    28123     +101     
==========================================
+ Hits        21043    21093      +50     
- Misses       5113     5151      +38     
- Partials     1866     1879      +13     

Flag	Coverage Δ
unittests	75.00% <64.48%> (-0.10%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
server/storage/storage.go	70.27% <ø> (ø)
server/grpc_service.go	51.72% <45.45%> (+0.34%)	⬆️
tools/pd-ctl/pdctl/command/min_resolved_ts.go	50.00% <50.00%> (ø)
server/storage/endpoint/min_resolved_ts.go	55.55% <55.55%> (ø)
server/cluster/cluster.go	83.52% <61.11%> (-0.85%)	⬇️
server/api/min_resolved_ts.go	72.72% <72.72%> (ø)
server/api/router.go	99.58% <100.00%> (+<0.01%)	⬆️
server/config/config.go	77.94% <100.00%> (+0.09%)	⬆️
server/config/persist_options.go	93.63% <100.00%> (+0.77%)	⬆️
server/core/store.go	81.68% <100.00%> (+0.34%)	⬆️
... and 20 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 844d138...3f9c788. Read the comment docs.

[nolouch]

this resloved ts is cluster-level, do we need the data center-level? such as, Primary DC scope resolved ts and DR DC scop resolved ts. cc @disksing

[nolouch]

I think this has unnecessary writes to etcd.

[lhy1024]

cc @disksing

[disksing]

It should be ok to write to etcd. If not write to etcd, it will be lost when PD is shut down or PD leader is changed.

[nolouch]

it only write meta information to etcd, actually there is no any update :

func (c *RaftCluster) putStoreLocked(store *core.StoreInfo) error {
	if c.storage != nil {
		if err := c.storage.SaveStore(store.GetMeta()); err != nil {
			return err
		}
	}
	c.core.PutStore(store)
	c.hotStat.GetOrCreateRollingStoreStats(store.GetID())
	return nil
}

[disksing]

this resloved ts is cluster-level, do we need the data center-level? such as, Primary DC scope resolved ts and DR DC scop resolved ts. cc @disksing

It should be cluster scope.

[AndreMouche]

1. Could or should we store the min_resolve_ts once we receive the request instead store it in goroutine?
2. the path min_resolved_ts is too big, maybe save it to a sub path?

[lhy1024]

1. Could or should we store the min_resolve_ts once we receive the request instead store it in goroutine?
2. the path min_resolved_ts is too big, maybe save it to a sub path?

1. if there are many stores, it could cause a performance problem. dr-ausosync: report min resolved ts #4716 (comment)

2. do you have a good idea about the path?

[nolouch]

it only write meta information to etcd, actually there is no any update :

func (c *RaftCluster) putStoreLocked(store *core.StoreInfo) error {
	if c.storage != nil {
		if err := c.storage.SaveStore(store.GetMeta()); err != nil {
			return err
		}
	}
	c.core.PutStore(store)
	c.hotStat.GetOrCreateRollingStoreStats(store.GetID())
	return nil
}

[nolouch]

/merge

[ti-chi-bot]

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 5d6c960

[ti-chi-bot]

@lhy1024: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.