Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: fix policy on any of in hot scheduler #5524

Merged
merged 1 commit into from
Sep 17, 2022

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Sep 17, 2022

Signed-off-by: lhy1024 [email protected]

What problem does this PR solve?

Issue Number: Ref #4949

What is changed and how does it work?

After #4912, we replace first-only with any-of, but it introduced an error that the result should be false when the dim is not selected with any-of policy.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 17, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HunDunDM
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Sep 17, 2022
@codecov
Copy link

codecov bot commented Sep 17, 2022

Codecov Report

Base: 75.72% // Head: 75.75% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (44b4a7f) compared to base (dcd84e6).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5524      +/-   ##
==========================================
+ Coverage   75.72%   75.75%   +0.02%     
==========================================
  Files         323      323              
  Lines       31988    31992       +4     
==========================================
+ Hits        24222    24234      +12     
+ Misses       5695     5676      -19     
- Partials     2071     2082      +11     
Flag Coverage Δ
unittests 75.75% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/schedulers/hot_region.go 85.58% <100.00%> (-0.19%) ⬇️
pkg/metricutil/metricutil.go 82.75% <0.00%> (-10.35%) ⬇️
server/id/id.go 83.05% <0.00%> (-10.17%) ⬇️
pkg/etcdutil/etcdutil.go 84.88% <0.00%> (-3.49%) ⬇️
pkg/dashboard/adapter/manager.go 79.31% <0.00%> (-2.30%) ⬇️
server/member/member.go 64.21% <0.00%> (-1.58%) ⬇️
server/server.go 75.06% <0.00%> (-1.40%) ⬇️
server/tso/tso.go 69.66% <0.00%> (-1.13%) ⬇️
server/region_syncer/server.go 86.26% <0.00%> (-1.10%) ⬇️
server/schedule/checker/rule_checker.go 80.28% <0.00%> (-0.97%) ⬇️
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 17, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 17, 2022
@nolouch
Copy link
Contributor

nolouch commented Sep 17, 2022

/merge

@ti-chi-bot
Copy link
Member

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 44b4a7f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 17, 2022
@ti-chi-bot ti-chi-bot merged commit 1218b4d into tikv:master Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants