-
Notifications
You must be signed in to change notification settings - Fork 727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: supports build pd-server with fail point #6946
Conversation
Signed-off-by: nolouch <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6946 +/- ##
==========================================
- Coverage 74.36% 74.33% -0.04%
==========================================
Files 427 427
Lines 45327 45334 +7
==========================================
- Hits 33706 33697 -9
- Misses 8651 8669 +18
+ Partials 2970 2968 -2
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: nolouch <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
/merge |
@nolouch: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 4dd911e
|
close tikv#4399 In order can use fail points in testing, need to build a special binary - supports build pd-server with fail point Signed-off-by: nolouch <[email protected]> Signed-off-by: rishabh_mittal <[email protected]>
What problem does this PR solve?
Issue Number: Close #4399
What is changed and how does it work?
Check List
Tests
Release note