Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: make TestAllocIDAfterLeaderChange more stable #8558

Merged
merged 3 commits into from
Aug 22, 2024
Merged

tests: make TestAllocIDAfterLeaderChange more stable #8558

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
343be44
make test stable
HuSharp Aug 22, 2024
98b6849
add more waitleader
HuSharp Aug 22, 2024
e23dcb5
Merge branch 'master' into make_alloc_stable
ti-chi-bot[bot] Aug 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tests/integrations/mcs/scheduling/server_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ func (suite *serverTestSuite) TestAllocIDAfterLeaderChange() {
pd2, err := suite.cluster.Join(suite.ctx)
re.NoError(err)
err = pd2.Run()
re.NotEmpty(suite.cluster.WaitLeader())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still some cases that are not judged empty, do we need also modify them or add comments?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added more waiting leaders for tests related to joining situation

re.NoError(err)
tc, err := tests.NewTestSchedulingCluster(suite.ctx, 1, suite.backendEndpoints)
re.NoError(err)
Expand Down