Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics: rename RegionStats in hot statistics #8740

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Oct 22, 2024

What problem does this PR solve?

Issue Number: Ref #4399

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 22, 2024
@lhy1024 lhy1024 changed the title statistics: rename "RegionStats" in hot statistics statistics: rename RegionStats in hot statistics Oct 22, 2024
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.03%. Comparing base (0402e15) to head (80451f5).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8740      +/-   ##
==========================================
- Coverage   70.10%   70.03%   -0.08%     
==========================================
  Files         517      517              
  Lines       79983    79964      -19     
==========================================
- Hits        56076    56003      -73     
- Misses      20339    20384      +45     
- Partials     3568     3577       +9     
Flag Coverage Δ
unittests 70.03% <100.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 22, 2024
Copy link
Contributor

ti-chi-bot bot commented Oct 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: okJiang, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 22, 2024
Copy link
Contributor

ti-chi-bot bot commented Oct 22, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-22 09:44:12.359409731 +0000 UTC m=+344253.056200359: ☑️ agreed by okJiang.
  • 2024-10-22 09:50:35.685296661 +0000 UTC m=+344636.382087271: ☑️ agreed by rleungx.

Signed-off-by: lhy1024 <[email protected]>
@lhy1024
Copy link
Contributor Author

lhy1024 commented Oct 22, 2024

/test pull-integration-realcluster-test

@okJiang
Copy link
Member

okJiang commented Oct 22, 2024

/retest

@lhy1024
Copy link
Contributor Author

lhy1024 commented Oct 23, 2024

/test pull-integration-realcluster-test

@ti-chi-bot ti-chi-bot bot merged commit d82e41d into tikv:master Oct 23, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants