-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Appveyor, bors related branch configuration #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
ice1000
previously approved these changes
Nov 1, 2018
This comment has been minimized.
This comment has been minimized.
bors bot
added a commit
that referenced
this pull request
Nov 1, 2018
137: Add Appveyor r=Hoverbear a=Hoverbear Adds appveyor so we can test our builds on Windows as well. Since I think none of our maintainers develop on Windows, this can possibly help us find portability bugs. Co-authored-by: Hoverbear <[email protected]>
This comment has been minimized.
This comment has been minimized.
@ice1000 Please take a look again. |
Hoverbear
changed the title
Add Appveyor
Add Appveyor, bors related branch configuration
Nov 1, 2018
ice1000
reviewed
Nov 1, 2018
breezewish
approved these changes
Nov 2, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds appveyor so we can test our builds on Windows as well. Since I think none of our maintainers develop on Windows, this can possibly help us find portability bugs.
Also sets up CI to build the branches bors checks things on.