dynamically set auto_tuned mode of WriteAmpBasedRateLimiter #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tabokie <[email protected]>
Signed-off-by: tabokie <[email protected]>
Signed-off-by: tabokie <[email protected]>
Signed-off-by: tabokie <[email protected]>
Signed-off-by: tabokie <[email protected]>
yiwu-arbug
reviewed
Dec 9, 2020
| max_bytes_per_sec_.store(bytes_per_second, std::memory_order_relaxed); | ||
| } else { | ||
| SetActualBytesPerSecond(bytes_per_second); | ||
| } | ||
| } | ||
|
|
||
| void WriteAmpBasedRateLimiter::SetAutoTuned(bool auto_tuned) { | ||
| MutexLock g(&auto_tuned_mutex_); | ||
| if (auto_tuned_.load(std::memory_order_relaxed) != auto_tuned) { |
There was a problem hiding this comment.
Let's use seq_cst order for all access to auto_tuned_?
There was a problem hiding this comment.
I think seq_cst is equivalent to acq_rel if only one variable is tagged. I went through the logic again and added some tags.
There was a problem hiding this comment.
yeah, using acquire/release ordering is even better, but sometimes they are hard to reason about. But as we are considering use arm, it make more sense for us to take some effort and use the acquire/release semantics if suitable.
Signed-off-by: tabokie <[email protected]>
Signed-off-by: tabokie <[email protected]>
Signed-off-by: tabokie <[email protected]>
|
pin @Connor1996 |
Signed-off-by: tabokie <[email protected]>
Connor1996
approved these changes
Dec 14, 2020
tabokie
added a commit
to tabokie/rocksdb
that referenced
this pull request
May 10, 2022
…kv#217) Add new APIs to `RateLimiter`, only implement it for `WriteAmpBasedRateLimiter`. Signed-off-by: tabokie <[email protected]>
tabokie
added a commit
that referenced
this pull request
May 11, 2022
Add new APIs to `RateLimiter`, only implement it for `WriteAmpBasedRateLimiter`. Signed-off-by: tabokie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: tabokie [email protected]
Add new setter API to
RateLimiter, only implement it forWriteAmpBasedRateLimiter.