Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug of using post write callback with empty batch #327

Merged
merged 2 commits into from
Jan 16, 2023

Conversation

tabokie
Copy link
Member

@tabokie tabokie commented Jan 16, 2023

Signed-off-by: tabokie [email protected]

@tabokie tabokie requested review from Connor1996 and BusyJay January 16, 2023 04:17
Signed-off-by: tabokie <[email protected]>
Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tabokie tabokie merged commit fdcd14d into tikv:6.29.tikv Jan 16, 2023
@tabokie tabokie deleted the fix-callback-empty branch January 16, 2023 07:30
v01dstar pushed a commit to v01dstar/rocksdb that referenced this pull request May 29, 2024
* fix bug of using post write callback with empty batch

Signed-off-by: tabokie <[email protected]>

* fix nullptr

Signed-off-by: tabokie <[email protected]>

Signed-off-by: tabokie <[email protected]>
v01dstar pushed a commit to v01dstar/rocksdb that referenced this pull request Oct 2, 2024
* fix bug of using post write callback with empty batch

Signed-off-by: tabokie <[email protected]>

* fix nullptr

Signed-off-by: tabokie <[email protected]>

Signed-off-by: tabokie <[email protected]>
Signed-off-by: Yang Zhang <[email protected]>
v01dstar pushed a commit to v01dstar/rocksdb that referenced this pull request Oct 2, 2024
* fix bug of using post write callback with empty batch

Signed-off-by: tabokie <[email protected]>

* fix nullptr

Signed-off-by: tabokie <[email protected]>

Signed-off-by: tabokie <[email protected]>
Signed-off-by: Yang Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants