Add utility function to orient MultiPolygons. #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the boundary code, we ensure that admin polygons are correctly oriented, with the interior on the left of their rings, before extracting those rings as boundary lines. However, the orient function from Shapely only handles Polygons, not MultiPolygons, and bails with an exception if it encounters a MultiPolygon. Sadly, many admin areas are indeed MultiPolygons. This adds a simple utility function to orient MultiPolygons by orienting all constituent Polygons.
rmarianski
approved these changes
Feb 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the boundary code, we ensure that admin polygons are correctly oriented, with the interior on the left of their rings, before extracting those rings as boundary lines. However, the orient function from Shapely only handles Polygons, not MultiPolygons, and bails with an exception if it encounters a MultiPolygon. Sadly, many admin areas are indeed MultiPolygons. This adds a simple utility function to orient MultiPolygons by orienting all constituent Polygons.