Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POI labels for parks show up too late / too early #1081

Closed
nvkelso opened this issue Sep 22, 2016 · 4 comments
Closed

POI labels for parks show up too late / too early #1081

nvkelso opened this issue Sep 22, 2016 · 4 comments

Comments

@nvkelso
Copy link
Member

nvkelso commented Sep 22, 2016

  • What did you see? Adirondack Park in NY state label only shows up at zoom 9, other minor parks show up way too early.
  • What did you expect to see? Adarondak should show up based on it's huge size more like 6. Other should be pushed back a few zooms.
  • What map location are you having problems with? New York state, San Francisco.
  • Screenshot?

7/43.804/-74.435
screen shot 2016-09-22 at 09 33 24

10/37.6180/-122.1185
screen shot 2016-09-22 at 09 37 44

Adding filters back on the labels like so seems to fix it (let's refine):

landuse-labels-green-areas-not-national-park:
                filter:
                    all:
                        - area: true
                        - $geometry: point
                        - kind: [park, conservation, protected_area, nature_reserve, forest, grass]
                    any:
                        # show labels for smaller landuse areas at higher zooms
                        - { $zoom: [5],    area: { min: 10000000000 } }
                        - { $zoom: [6,7],  area: { min: 5000000000 } }
                        - { $zoom: [8],    area: { min: 1000000000 } }
                        - { $zoom: [9],    area: { min: 100000000 } }
                        - { $zoom: [10],   area: { min: 50000000 } }
                        - { $zoom: [11],   area: { min: 25000000 } }
                        - { $zoom: [12],   area: { min: 5000000 } }
                        - { $zoom: [13],   area: { min: 200000 } }
                        - { $zoom: [14],   area: { min: 50000 } }
                        - { $zoom: [15],   area: { min: 10000 } }
                        - { $zoom: [16],   area: { min: 1000 } }
                        - { $zoom: { min: 17 }, area: true }
@zerebubuth
Copy link
Member

For example, Lands End Park in SF has a way_area of 1,712,730 and is in tier 2 (because leisure=park and not US Parks Service). The tier 2 min zoom for something between 1,000,000 and 5,000,000 is 10. Which is what this POI has.

Adirondack Park seems to have been demoted to zoom 9 because it's not operated by the operators we promote, doesn't have the right protect class, etc... so it falls in with the "miscellaneous" parks which are limited to zoom 9.

@nvkelso nvkelso modified the milestones: v1.1.0, v1.2.0 Apr 25, 2017
@nvkelso
Copy link
Member Author

nvkelso commented Jul 27, 2017

Not clear how much an issue this is still.

@nvkelso
Copy link
Member Author

nvkelso commented Jul 27, 2017

Subtask of #1351.

@nvkelso nvkelso modified the milestones: v1.5.0, v1.6.0 Nov 28, 2017
@nvkelso nvkelso modified the milestones: v1.6.0, v1.7.0 Sep 25, 2018
@nvkelso nvkelso modified the milestones: v1.8.0, v1.7.0 Dec 29, 2018
@nvkelso
Copy link
Member Author

nvkelso commented Dec 29, 2018

Duplicate of #1609, closing.

@nvkelso nvkelso closed this as completed Dec 29, 2018
@ghost ghost removed the nextnext label Dec 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants